Closed
Bug 1093839
Opened 10 years ago
Closed 10 years ago
nsDocShell::SerializeJSValVariant declared but not defined
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: tromey, Assigned: tromey)
Details
Attachments
(1 file)
1.36 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
nsDocShell.h has: // Tries to serialize a given variant using structured clone. This only // works if the variant is backed by a JSVal. nsresult SerializeJSValVariant(JSContext *aCx, nsIVariant *aData, nsAString &aResult); However this is never defined anywhere. I think it's just a leftover, though I didn't dig to find out when it was removed. Patch to follow.
Assignee | ||
Comment 1•10 years ago
|
||
This removes the declaration. Tested by rebuilding.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ttromey
Assignee | ||
Updated•10 years ago
|
Attachment #8516943 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8516943 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/71c607c0f4f2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71c607c0f4f2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•