1093857 - switch to pytest and pytest-django

Status: RESOLVED FIXED

(Input Graveyard :: Code Quality, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We currently use nose and django-nose for tests. django-nose hasn't had a release since mid-2013. It's not actively maintained. nose is undergoing a complete rewrite for nose 2.

pytest and pytest-django are both actively maintained and pytest-django is more likely to work with newer versions of django as they're released.

We currently use pytest for the smoketests since that's what QA uses and our smoketest code is based on their infrastructure.

This bug covers researching switching from nose/django-nose to pytest/pytest-django. Namely:

1. does pytest meet the requirements we have (fail fast, run a specific test, test skipping, db reuse, fast test-and-fix development cycle, ...)?

2. how much effort is it to switch from nose to pytest?

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ran out of time this quarter. Pushing it off until next quarter.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm going to make this block Django 1.8 upgrade to answer the following question:

    Do we need to do this to upgrade to Django 1.8?

If not, we should push this off indefinitely. Further, we should do this when/if SUMO is ready to do the same so the two projects continue to have similar infrastructure.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Unblocking in favor of bug 1164031

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

AMO did this in this PR: https://github.com/mozilla/olympia/pull/369

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this now to toy with.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Switching this from a research project to an implementation bug.

In a PR: https://github.com/mozilla/fjord/pull/609

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master.

This isn't related to our servers, so I'm going to close this out now.