Devedition theme: search box appears dark even when inside of the customize menu

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bgrins, Assigned: jsantell)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox35 fixed, firefox36 affected)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 8516965 [details]
search-box-customize.png

See screenshot.  We should only style this as such if it's inside of #navigator-toolbox
(Reporter)

Updated

4 years ago
Blocks: 1053434
(Reporter)

Comment 1

4 years ago
Jordan said he would look at this
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Created attachment 8517208 [details] [diff] [review]
1093866-search-dark-theme.patch

That did the trick, Brian. Looks good now, not sure what the landing process is for style bugs for dev ed.
Attachment #8517208 - Flags: review?(bgrinstead)
Comment on attachment 8517208 [details] [diff] [review]
1093866-search-dark-theme.patch

The location bar cannot be moved away from the toolbar.
Attachment #8517208 - Flags: review?(bgrinstead) → review-
Created attachment 8517532 [details] [diff] [review]
1093866-search-dark-theme.patch

Ah, I see what you're saying Dão -- removed the styling for the urlbar change
Attachment #8517208 - Attachment is obsolete: true
Attachment #8517532 - Flags: review?(bgrinstead)
Comment on attachment 8517532 [details] [diff] [review]
1093866-search-dark-theme.patch

You could also use '#search-container[cui-areatype="toolbar"] > #searchbar > .searchbar-textbox' and thereby avoid the descendent selector.
Attachment #8517532 - Flags: review?(bgrinstead) → review+
(Reporter)

Comment 6

4 years ago
Created attachment 8517726 [details] [diff] [review]
search-bar-jsantell-r=dao.patch

Jordan's patch to land after fx-team reopens (updated commit message)
Attachment #8517532 - Attachment is obsolete: true
Attachment #8517726 - Flags: review+
(Reporter)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/a7da97e14dd3
status-firefox35: --- → fixed
status-firefox36: --- → affected
Whiteboard: [fixed-in-fx-team]
(Reporter)

Updated

4 years ago
Group: mozilla-employee-confidential
(Reporter)

Comment 9

4 years ago
https://hg.mozilla.org/mozilla-central/rev/4d284c7760bf
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.