Closed Bug 1093866 Opened 5 years ago Closed 5 years ago

Devedition theme: search box appears dark even when inside of the customize menu

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox35 --- fixed
firefox36 --- affected

People

(Reporter: bgrins, Assigned: jsantell)

References

Details

Attachments

(2 files, 2 obsolete files)

See screenshot.  We should only style this as such if it's inside of #navigator-toolbox
Blocks: 1053434
Jordan said he would look at this
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attached patch 1093866-search-dark-theme.patch (obsolete) — Splinter Review
That did the trick, Brian. Looks good now, not sure what the landing process is for style bugs for dev ed.
Attachment #8517208 - Flags: review?(bgrinstead)
Comment on attachment 8517208 [details] [diff] [review]
1093866-search-dark-theme.patch

The location bar cannot be moved away from the toolbar.
Attachment #8517208 - Flags: review?(bgrinstead) → review-
Attached patch 1093866-search-dark-theme.patch (obsolete) — Splinter Review
Ah, I see what you're saying Dão -- removed the styling for the urlbar change
Attachment #8517208 - Attachment is obsolete: true
Attachment #8517532 - Flags: review?(bgrinstead)
Comment on attachment 8517532 [details] [diff] [review]
1093866-search-dark-theme.patch

You could also use '#search-container[cui-areatype="toolbar"] > #searchbar > .searchbar-textbox' and thereby avoid the descendent selector.
Attachment #8517532 - Flags: review?(bgrinstead) → review+
Jordan's patch to land after fx-team reopens (updated commit message)
Attachment #8517532 - Attachment is obsolete: true
Attachment #8517726 - Flags: review+
Keywords: checkin-needed
Group: mozilla-employee-confidential
https://hg.mozilla.org/mozilla-central/rev/4d284c7760bf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.