Closed Bug 1093875 Opened 7 years ago Closed 7 years ago

XBL anonymous content cannot be inspected inside of an HTML document

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file, 1 obsolete file)

These lines are ignoring native anon content if we aren't in a XUL document: http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/inspector.js#3249-3256.

But in the case of http://limpet.net/mbrubeck/atom.xml the yellow box at the top with subscribe controls cannot be inspected.  In this case the XUL is inside of a non-XUL document.
Attached patch xul-anon-WIP.patch (obsolete) — Splinter Review
This works for me locally, but I won't have time to get this tested and reviewable at the moment.  Probably not until next week at least, but feel free to apply the patch locally if you need it to get work done.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attached patch xul-anon.patchSplinter Review
Patrick, there was an issue with XBL content not showing up when loaded in an HTML document (because the check was just looking at the element's ownerDocument).  I've updated this and added a test.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5e03b8dab303
Attachment #8516989 - Attachment is obsolete: true
Attachment #8522582 - Flags: review?(pbrosset)
Comment on attachment 8522582 [details] [diff] [review]
xul-anon.patch

Review of attachment 8522582 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #8522582 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/becaa9efc9b7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
See Also: → 1187482
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.