1093875 - XBL anonymous content cannot be inspected inside of an HTML document

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Brian Grinstead [:bgrins]]

These lines are ignoring native anon content if we aren't in a XUL document: http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/inspector.js#3249-3256.

But in the case of http://limpet.net/mbrubeck/atom.xml the yellow box at the top with subscribe controls cannot be inspected.  In this case the XUL is inside of a non-XUL document.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: xul-anon-WIP.patch

This works for me locally, but I won't have time to get this tested and reviewable at the moment.  Probably not until next week at least, but feel free to apply the patch locally if you need it to get work done.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: xul-anon.patch

Patrick, there was an issue with XBL content not showing up when loaded in an HTML document (because the check was just looking at the element's ownerDocument).  I've updated this and added a test.  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5e03b8dab303

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8522582 [details] [diff] [review]
xul-anon.patch

Review of attachment 8522582 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/becaa9efc9b7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/becaa9efc9b7