Closed Bug 1093883 Opened 7 years ago Closed 7 years ago

Disable app install for runtimes that don't allow it

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: jryans, Assigned: paul)

References

Details

Attachments

(1 file)

Some people during Dev. Edition trials attempted to install an app to:

* Local Runtime
* Chrome Desktop

This does not work because they don't support apps today, but we still let you try, which confusing.
Paul, maybe you want to look at this?
Flags: needinfo?(paul)
I was thinking we could disable based on whether the webapps actor exists.
Yes. And we can add a warning/error to details.xhtml to say that the app can not be installed on this runtime.
Flags: needinfo?(paul)
Attached patch v1Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8519729 - Flags: review?(jryans)
Duplicate of this bug: 1084281
I don't have any iOS device at the moment to test this patch.
Comment on attachment 8519729 [details] [diff] [review]
v1

Review of attachment 8519729 [details] [diff] [review]:
-----------------------------------------------------------------

Works as intended for Chrome and iOS. (P.S. if you have a Mac but no iOS device, you can also connect to the iOS Simulator.)

For the Local Runtime, the play button is still enabled, but then fails with "Not B2G. Can't launch app.".  What's a good way to do better here?  We could use a trait on Firefox desktop like "webappsLaunch: false", or something.  Does that seem like that a good idea?  Anyway, probably best in a followup.
Attachment #8519729 - Flags: review?(jryans) → review+
(In reply to J. Ryan Stinnett [:jryans] from comment #8)
> Comment on attachment 8519729 [details] [diff] [review]
> v1
> 
> Review of attachment 8519729 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works as intended for Chrome and iOS. (P.S. if you have a Mac but no iOS
> device, you can also connect to the iOS Simulator.)
> 
> For the Local Runtime, the play button is still enabled, but then fails with
> "Not B2G. Can't launch app.".  What's a good way to do better here?  We
> could use a trait on Firefox desktop like "webappsLaunch: false", or
> something.  Does that seem like that a good idea?  Anyway, probably best in
> a followup.

Yes. I saw that (that's why I had to change how errors are displayed).

Because we can't do much with the apps actor on Firefox desktop, we should not register this actor for the browser.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/8f922593c776
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8f922593c776
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.