1093883 - Disable app install for runtimes that don't allow it

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Some people during Dev. Edition trials attempted to install an app to:

* Local Runtime
* Chrome Desktop

This does not work because they don't support apps today, but we still let you try, which confusing.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Paul, maybe you want to look at this?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I was thinking we could disable based on whether the webapps actor exists.

Comment 3

[Paul Rouget [:paul]]

Yes. And we can add a warning/error to details.xhtml to say that the app can not be installed on this runtime.

Comment 4

[Paul Rouget [:paul]]

Attachment: v1

Comment 6

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=ec8d63584bc1

Comment 7

[Paul Rouget [:paul]]

I don't have any iOS device at the moment to test this patch.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8519729 [details] [diff] [review]
v1

Review of attachment 8519729 [details] [diff] [review]:
-----------------------------------------------------------------

Works as intended for Chrome and iOS. (P.S. if you have a Mac but no iOS device, you can also connect to the iOS Simulator.)

For the Local Runtime, the play button is still enabled, but then fails with "Not B2G. Can't launch app.".  What's a good way to do better here?  We could use a trait on Firefox desktop like "webappsLaunch: false", or something.  Does that seem like that a good idea?  Anyway, probably best in a followup.

Comment 10

[Paul Rouget [:paul]]

(In reply to J. Ryan Stinnett [:jryans] from comment #8)
> Comment on attachment 8519729 [details] [diff] [review]
> v1
> 
> Review of attachment 8519729 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works as intended for Chrome and iOS. (P.S. if you have a Mac but no iOS
> device, you can also connect to the iOS Simulator.)
> 
> For the Local Runtime, the play button is still enabled, but then fails with
> "Not B2G. Can't launch app.".  What's a good way to do better here?  We
> could use a trait on Firefox desktop like "webappsLaunch: false", or
> something.  Does that seem like that a good idea?  Anyway, probably best in
> a followup.

Yes. I saw that (that's why I had to change how errors are displayed).

Because we can't do much with the apps actor on Firefox desktop, we should not register this actor for the browser.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8f922593c776

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f922593c776