Closed
Bug 1093967
Opened 8 years ago
Closed 8 years ago
Implement BlitFramebuffer
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(3 files)
4.29 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
33.65 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
12.88 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8517116 -
Flags: review?(dvander)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8517117 -
Flags: review?(dvander)
Assignee | ||
Updated•8 years ago
|
Attachment #8517115 -
Flags: review?(dvander)
Attachment #8517115 -
Flags: review?(dvander) → review+
Comment on attachment 8517116 [details] [diff] [review] 0002-Fix-all-instances-of-mBoundFramebuffer.patch Review of attachment 8517116 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLContextValidate.cpp @@ +1799,5 @@ > + break; > + } > + > + if (MOZ_LIKELY(isValid)) { > + return true; I'd just return true in the above cases, unless something else will need to be validated in a later patch.
Attachment #8517116 -
Flags: review?(dvander) → review+
Comment on attachment 8517117 [details] [diff] [review] 0003-Implement-BlitFramebuffer.patch Review of attachment 8517117 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGL2ContextFramebuffers.cpp @@ +276,5 @@ > + * and destination depth and stencil buffer formats do not match. > + * > + * jgilbert: The wording is such that if only DEPTH_BUFFER_BIT is specified, > + * the stencil formats must match. This seems wrong. It could be a spec bug, > + * or I could be missing an interaction in one of the earlier paragraphs. Yeah, I read this as "if X or Y, then x or y should match respectively."
Attachment #8517117 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 5•8 years ago
|
||
The only unambiguous reading of the passage is problematic, though. 'Reasonable interpretation' doesn't really cut it for specs.
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88cf7f2fe48f
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8d48c34f44ed for build bustage: https://treeherder.mozilla.org/logviewer.html#?job_id=5300122&repo=mozilla-inbound
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #7) > Backed out in > https://hg.mozilla.org/integration/mozilla-inbound/rev/8d48c34f44ed for > build bustage: > https://treeherder.mozilla.org/logviewer.html#?job_id=5300122&repo=mozilla- > inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/32e93a36551d The bustage was from conflicts with the shader rewrite stuff, which was also backed out.
Flags: needinfo?(jgilbert)
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32e93a36551d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•