Closed Bug 1094003 Opened 10 years ago Closed 10 years ago

[Text Selection] Pop-up menu UI improvement

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Window Mgmt
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Carol, Unassigned)

Details

Attachments

(3 files)

imgo.jpg
59.34 KB, image/jpeg
Details
screenshot.png
129.51 KB, image/png
Carol
: ui-review+
Details
PR to master
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
Attached image imgo.jpg — 
      No description provided.
Hi George,
The divider looks like green color but the divider color on UI spec was #596466.
Please help check the divider color, thanks!

For the pop-up menu, please make the shadow 1px(x,y) closer to the menu body.
Flags: needinfo?(gduan)
Hi George,
please help me change the divider color to #525b5e, pop-up bg is #606b6e
Attached image screenshot.png — 
Hi Carol,
plz kindly review this ui part, thanks!
Flags: needinfo?(gduan)
Attachment #8519733 - Flags: ui-review?(chuang)
Attached file PR to master — 
Hi Alive,
could you review the ui change? Thanks.
Attachment #8519736 - Flags: review?(alive)
Comment on attachment 8519733 [details]
screenshot.png

Good!thanks, George.
Attachment #8519733 - Flags: ui-review?(chuang) → ui-review+
Attachment #8519736 - Flags: review?(alive) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: