Closed
Bug 1094020
Opened 10 years ago
Closed 3 years ago
Remove the MOZ_WIDGET_GONK build flag for OverlayImage implementation
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: shelly, Unassigned)
References
Details
Attachments
(2 files)
18.42 KB,
patch
|
Details | Diff | Splinter Review | |
5.69 KB,
patch
|
Details | Diff | Splinter Review |
This new type of image might be applied to other platform as well, and since the implementation of OVerlayImage is not gonk-dependent, we might want to remove the build flag of MOZ_WIDGET_GONK.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(chung)
Comment 2•10 years ago
|
||
The patch looks good for me, I am still debugging why it not work on desktop.
Flags: needinfo?(chung)
Comment 3•10 years ago
|
||
This patch fixes the missing part of your oringinal patch. While debugging, I found it works on B2G by some maybe problematic behaviour: [1] is always run on B2G, but not desktop. This maybe a layer recycling bug on B2G. The overlay image patch creates a new ImageClient in ImageContainer, which is attached to the ImageLayer in [2], so we should handle such change. By the way, this may still not puncture hole on some platform, since this patch and original overlay image patch works only for CompositorOGL, if you want to it works on linux, you will need fix BasicCompositor. So I think we may need a good reason to change correspond part on different compositor. @shelly BTW, can you add test case after your TV media stream part complete? [1] http://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientImageLayer.cpp?from=ClientImageLayer.cpp#155 [2] http://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ImageClient.cpp?from=ImageClient.cpp&case=true#425
Reporter | ||
Comment 4•10 years ago
|
||
Hi Marco, according to Chiajung's comment 3, it seems that removing the build flag of b2g only isn't a doddle, how do you think about that?
Reporter | ||
Comment 5•10 years ago
|
||
Hi Chiajung, after discussing with Marco, we will keep the OverlayImage as b2g only for now, but since it looks like the current implementation for b2g is base on a problematic bug, we will still leave it as a follow-up issue.
Blocks: 1026358
Comment 6•10 years ago
|
||
I think it is okay to leave as a follow up of the maybe problematic behavior. I think we should also follow up any further requirement about it in this bug. :)
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•