1094031 - Let |LayoutManager. _updateCurrentPage| use |LayoutNormalizer. _normalizeKey|

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Inspired by bug 1092930, let's use the key normalization function in LayoutManager to reduce the amount of hardcoded and/or duplicated properties/logics.

Comment 1

[[e-mail]]

Hi John,
  I updated the pull request for bug 1092930, you can take a look.

(In reply to John Lu [:mnjul] [MoCoTPE] from comment #0)
> Inspired by bug 1092930, let's use the key normalization function in
> LayoutManager to reduce the amount of hardcoded and/or duplicated
> properties/logics.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

On this.

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Getting it tested for integration...

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Final try before landing: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c8674836e018

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/1abe09b4925547699dfdb2d358aed019137c3aa6