Closed
Bug 1094038
Opened 10 years ago
Closed 10 years ago
Spelling mistakes
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Webmaker Graveyard
Popcorn Maker
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: george, Assigned: george)
Details
Attachments
(1 file)
No description provided.
Comment 2•10 years ago
|
||
Hey George! Thanks for the pull request and fixes. Really awesome your helping cover some of our slip ups :) I did leave a few comments for you to address. Once we get those covered we can merge this in! Thanks again!
Assignee: nobody → george
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•10 years ago
|
Attachment #8517227 -
Flags: review-
Updated the the pull request, let me know if you would lime me to squash the commits together.
Comment 4•10 years ago
|
||
Comment on attachment 8517227 [details] [review] Spelling corrections Hey George, Thanks again! Looks good. If you want to squash them into one commit that would be great. Just make sure you push the updated squashed branch to the PR too! Cheers
Attachment #8517227 -
Flags: review- → review+
Comment 5•10 years ago
|
||
Keep in mind, I will gladly squash this myself sometime at the end of today if you don't get a chance. I just want to let you do it yourself if you are interested. Cheers
Comment 6•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/6cfc52646b167f9d74a8d2f8f2ec0c06c308eda8 Bug 1094038 - Spelling mistakes
Comment 7•10 years ago
|
||
Thanks again for the help George! :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•