Status

Webmaker
Popcorn Maker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: george, Assigned: george)

Tracking

Details

Attachments

(1 attachment)

56 bytes, text/x-github-pull-request
mjschranz
: review+
Details | Review | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8517227 [details] [review]
Spelling corrections
Hey George!

Thanks for the pull request and fixes. Really awesome your helping cover some of our slip ups :)

I did leave a few comments for you to address. Once we get those covered we can merge this in!

Thanks again!
Assignee: nobody → george
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8517227 - Flags: review-
(Assignee)

Comment 3

4 years ago
Updated the the pull request, let me know if you would lime me to squash the commits together.
Comment on attachment 8517227 [details] [review]
Spelling corrections

Hey George,

Thanks again! Looks good. If you want to squash them into one commit that would be great. Just make sure you push the updated squashed branch to the PR too!

Cheers
Attachment #8517227 - Flags: review- → review+
Keep in mind, I will gladly squash this myself sometime at the end of today if you don't get a chance. I just want to let you do it yourself if you are interested.

Cheers
Thanks again for the help George! :)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.