Closed Bug 1094063 Opened 10 years ago Closed 10 years ago

Transparent borders are not transparent enough when a border-radius is used

Categories

(Core :: Graphics, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox35 --- unaffected
firefox36 + fixed

People

(Reporter: nayinain, Assigned: jwatt)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached file test.html
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141104030202

Steps to reproduce:

Open the test.html


Actual results:

A darker than B.


Expected results:

A and B are the same color.
Attached image capture.gif
Do you know whether this is a regression or an existing problem in Firefox 33, say?

I can't reproduce on Mac, so almost certainly graphics, not layout.
Component: Layout → Graphics
Flags: needinfo?(nayinain)
(In reply to Boris Zbarsky [:bz] from comment #2)
> Do you know whether this is a regression or an existing problem in Firefox
> 33, say?
> 
> I can't reproduce on Mac, so almost certainly graphics, not layout.

regression window(m-c)
good:
20141103030205
https://hg.mozilla.org/mozilla-central/rev/0b81c10a9074

Bad:
20141104030202
https://hg.mozilla.org/mozilla-central/rev/5dde8ea48fef

No problem in FX33

maybe Bug 1092222, Bug 1092351, Bug 1092392 ?
Flags: needinfo?(nayinain)
[Tracking Requested - why for this release]:

Pushlog
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1533eef79502&tochange=2b0217193d51

Regressed by: Bug 1091787
Blocks: 1091787
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Assignee: nobody → jwatt
OS: Windows 7 → All
Hardware: x86 → All
Attached patch patchSplinter Review
We're painting the border twice because I accidentally dropped a return statement.
Attachment #8517429 - Flags: review?(matt.woodrow)
Attachment #8517429 - Flags: review?(matt.woodrow) → review+
Can you please add a test for this?
Flags: needinfo?(jwatt)
Blocks: 1094480
Flags: needinfo?(jwatt)
Summary: Wrong border-color rendered using with border-radius. → Transparent borders are not transparent enough when a border-radius is used
Flags: needinfo?(jwatt)
Comment on attachment 8517429 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/659aa8bd45c6

I also reverted most of the fuzz that was added in bug 1091787 part 1:

https://hg.mozilla.org/integration/mozilla-inbound/rev/03be055662c8

(In reply to Boris Zbarsky [:bz] from comment #6)
> Can you please add a test for this?

Yup, did so.
Flags: needinfo?(jwatt)
Attachment #8517429 - Flags: checkin+
The test I added for bug 1094480 would also have caught this.
No longer blocks: 1094480
nayinain: Thanks for the reduced testcase, that helped speed up the fix.
Blocks: 1097119
(In reply to Jonathan Watt [:jwatt] from comment #7)
> I also reverted most of the fuzz that was added in bug 1091787 part 1:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/03be055662c8

And yet more fuzz removal and disabled test enabling that I'll tack on here:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9eb1c6b2410
You need to log in before you can comment on or make changes to this bug.