Closed Bug 1094090 Opened 5 years ago Closed 5 years ago

Should be declared that trusted apps doesn't have |homescreen-webapps-manage| permission

Categories

(Core Graveyard :: DOM: Apps, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: junior, Assigned: fitzer.c)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Truested apps doesn't have |homescreen-webapps-manage| permission. The fact should be declared explicitly in dom/apps/PermissionsTable.jsm
Whiteboard: [good first bug]
Assignee: nobody → gachen
Attachment #8521116 - Flags: review?(fabrice)
Comment on attachment 8521116 [details] [diff] [review]
Added trusted: DENY_ACTION for homescreen-webapps-manage

Review of attachment 8521116 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8521116 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/2498fca6fea4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
The docs are somewhat ambiguous at this point. Do I commit the change or does somebody else have to?
(In reply to chris from comment #5)
> The docs are somewhat ambiguous at this point. Do I commit the change or
> does somebody else have to?

We did already, since you don't have the privileges to do so yourself. That's why the bug was marked as RESOLVED FIXED when it was merged into mozilla-central.

Thanks for your contribution!
I was working on this and waiting for try-server result.
Reassign to Chris since he solved the issue.
Assignee: gachen → fitzer.c
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.