Closed
Bug 1094090
Opened 9 years ago
Closed 9 years ago
Should be declared that trusted apps doesn't have |homescreen-webapps-manage| permission
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: CuveeHsu, Assigned: fitzer.c)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
1.26 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Truested apps doesn't have |homescreen-webapps-manage| permission. The fact should be declared explicitly in dom/apps/PermissionsTable.jsm
Reporter | ||
Updated•9 years ago
|
Whiteboard: [good first bug]
Attachment #8521116 -
Flags: review?(fabrice)
Comment 2•9 years ago
|
||
Comment on attachment 8521116 [details] [diff] [review] Added trusted: DENY_ACTION for homescreen-webapps-manage Review of attachment 8521116 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8521116 -
Flags: review?(fabrice) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2498fca6fea4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
The docs are somewhat ambiguous at this point. Do I commit the change or does somebody else have to?
Comment 6•9 years ago
|
||
(In reply to chris from comment #5) > The docs are somewhat ambiguous at this point. Do I commit the change or > does somebody else have to? We did already, since you don't have the privileges to do so yourself. That's why the bug was marked as RESOLVED FIXED when it was merged into mozilla-central. Thanks for your contribution!
I was working on this and waiting for try-server result. Reassign to Chris since he solved the issue.
Assignee: gachen → fitzer.c
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•