1094091 - [Stingray] Scaffolding Apps Deck of Stingray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

To scaffold apps deck of stingray project, which is an app essentially.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Evelyn and John,

Please help to review the patch. 

Here are the things I do in this patch:
1. Copy applications.js (from homescreen-stingray) into tv_shared, but it needs refinement. Because smart-settings app have dependency on it too.
2. Move smart-home/js/utils.js to tv_shared/shared_utils.js
3. Enable launch of app-deck from smart-home
4. Load apps and their icons, display them in app-deck


And the things I will do in next bug (bug 1094094) are:
1. Make |app-deck-list| scrollable
2. Enable app launch in app-deck
3. refine styling based on UI/UX spec (It is not completed yet)
4. l10n work of app-deck


Thanks

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8522085 [details] [review]
pull request

Since I am using module developed by Rex, I'll let Rex review my patch. (and f? John Hu)

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8522085 [details] [review]
pull request

Please see the comments in PR to find a memory leak.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8522085 [details] [review]
pull request

Looks mostly good to me but please fix comments before landing.
Thank you!

Comment 5

[Evelyn Hung]

Comment on attachment 8522085 [details] [review]
pull request

It looks good to me, but we still need Gaia owner for rubberstamp, so redirect to Tim.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Squash commits, rebase to latest master, and waiting Gaia-Try result 
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ed47b9741b1d

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #6)
> Squash commits, rebase to latest master, and waiting Gaia-Try result 
                                               ^^^^^^^ I mean 'wait for'
> https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ed47b9741b1d

Comment 8

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Landed on master 
https://github.com/mozilla-b2g/gaia/commit/279cbfe6b21fb81ee004220e59c6ef3111349deb