1094105 - [Flame][v2.1][Email]The URL hyperlink in mail content can't work before the sender's image signature is loaded completely.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Alissa（leave from Mozilla）]

Attachment: logcat.txt

[1.Description]:
After receiving a mail whose sender has an image signature,the URL in content will not show in hyperlink state before image is downloaded completely.
Occurence time:16:28
see attachments:logcat.txt,VID_0001_Compress.MP4
[2.Testing Steps]: 
1.Sen a mail with URL to test divce.
2.Launch email on test device.
3.Tap the mail received.
4.Tap the URL.
5.Tap the image prompt and download image.
6.Tap the URL agian.

[3.Expected Result]: 
The URL hyperlink in content  should work normally.

[4.Actual Result]: 
4.The URL hyperlink in content  can't work.
6.The URL hyperlink in content  can work

[5.Reproduction build]: 
Gaia-Rev        6926165a173549f2f76f26266cb5121d0411e703

Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dd48bef1b27e

Build-ID        20141028161205

Version         34.0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

Comment 1

[Alissa（leave from Mozilla）]

Attachment: VID_0001_Compress.MP4

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

In iframe_shims.js we do some sketchy math for click correcting; it's possible that when we overhauled the external/embedded images UI to be at the top instead of the bottom that we broke the math.  Proposing James to investigate this.  It might not have gotten noticed because at least most of the tests I run for this it tends to be large chunky images that are sliced and diced so we still could hit a hot click area and it might not be obvious if the wrong link is getting clicked.

Comment 3

[James Burke [:jrburke]]

Attachment: GitHub pull request

:asuth was correct, the click targets are not accurately calculated when the "Show external images" load bar shows above the content.

The issue was introduced in bug 1043527, which was applied to 2.1 but is not in 2.0. So, this fix should be uplifted to 2.1 once it is reviewed and landed on master.

Fix was simple, just account for the height of the bar when there.

Comment 4

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/255e6f8e13a6c872d615d800f140e964f273242b

from pull request:
https://github.com/mozilla-b2g/gaia/pull/25864

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8517899 [details] [review]
GitHub pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 1043527 - email UI: "Show external images" styling, a bug fixed in 2.1 and higher.

[User impact] if declined:
User will not be able to tap on hyperlinks in email when "Show external images" option is showing.

[Testing completed]:
On flame device on master.

[Risk to taking this patch] (and alternatives if risky):
Very low risk. Just gets the DOM height of the "Show External Images" and removes it from calculating the y coordinate for the tap. Tested when external images area was hidden (so value is zero, a number) and expanded (value of 42). No errors reported in logs, and even better, the taps on the links work.

[String changes made]:
None

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 8517899 [details] [review]
GitHub pull request

Approving given the bug is a fallout from a 2.1 feature landing 1043527 and is a functional breakage for end user.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/8c6f5921a2e67568d7ab233a6cc7fbfbb6494ae1

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The URL is accessible from the email without loading the image.

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141112001201
Gaia: 4c159e75a1568afbbf0c83c1235ec56facfbe87d
Gecko: b9849b3c6aaa
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 (319mb, KK, Shallow Flash)
BuildID: 20141112040208
Gaia: 5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko: 688f821edcd4
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0