Closed Bug 1094141 Opened 6 years ago Closed 6 years ago

Don't export skia APIs from xul.dll.

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file, 1 obsolete file)

7.11 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — Splinter Review
Inspired by bug 1092151. Although it doesn't cause build problems, we still don't want to export those.
Attachment #8517362 - Flags: review?(mh+mozilla)
Comment on attachment 8517362 [details] [diff] [review]
fix

Review of attachment 8517362 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/skia/generate_mozbuild.py
@@ +93,5 @@
>      DEFINES['SK_FONTHOST_DOES_NOT_USE_FONTMGR'] = 1
>  
>  # We should autogenerate these SSE related flags.
>  
>  if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':

Remove this line
Attachment #8517362 - Flags: review?(mh+mozilla) → feedback+
This if is also about some other defines. Those are, however, MSVC-specific. For GCC, header files take care of SSE defines based on GCC defines. I changed this to be used only for MSVC and also moved CLANG_CL flags.
Attached patch fix v2Splinter Review
Attachment #8517362 - Attachment is obsolete: true
Attachment #8518851 - Flags: review?(mh+mozilla)
Attachment #8518851 - Flags: feedback?(ehsan.akhgari)
Attachment #8518851 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c49c2442f666
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8518851 [details] [diff] [review]
fix v2

Review of attachment 8518851 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't tested this with clang-cl yet, but if this has broken those builds I will fix it separately.
Attachment #8518851 - Flags: feedback?(ehsan.akhgari)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.