1094185 - [DSDS] Make testvars.json handle 2 SIMs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

To implement the DSDS tests, we need to update the structure of testvars.json. My first idea would be to change the key "carrier" to "carriers" and have an array of carriers like:
>    "carriers": [{
>      "phone_number": "123456789",
>      "country": "United States",
>      "network": "Carrier1"
>    },{
>      "phone_number": "987654321",
>      "country": "United States",
>      "network": "Carrier2"
>    }],

This change would imply to modify the 18 occurrences in gaia-ui-tests, the credentials in webqa-credentials and the testvars.json from every person running these tests. For that I propose update the credential on 1 device in the lab and run the the entire test suite. Then, send an email to gaia-ui-automation to tell people to update their file.


Another modification could be to add a new key called "dsds" and put the carrier info there. No modification would be needed for the current test suite and the credential. One problem I see here is a semantic issue (same kind of data in 2 different keys).

Comment 1

[Johan Lorenzo [:jlorenzo]]

What are your takes on this, guys?

Comment 2

[Florin Strugariu [:Bebe]]

As we have the IMEI as a list. I would like to continue using the same syntax. I don't think we will have any big issues updating our local testvars and test files

Comment 3

[Zac C (:zac)]

It seems OK to me.
The country and carrier I originally added for marketplace payment testing and it's not used AFAIK. The carrier can on the rare occasion be useful sometimes if there's different behaviour between carriers' SIMs.

IMO You can remove it unless you think there's a reason we'll need it again in the future.

Comment 4

[Martijn Wargers (dead)]

Note bug 991518 and bug 972263.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

21 occurrences of "testvars['carrier']" found for now.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Credentials PR

Comment 7

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR 2.1

If we change the credentials, we would need to quickly change 2.1 as well.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Like :mwargers said on IRC, it's more prudent to clean up the carrier afterwards. Let's track this in 1096268.

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 8519875 [details] [review]
Gaia PR 2.1

This is r+, provided you address:
https://github.com/mozilla-b2g/gaia/pull/26002/files#diff-46a9fb36b96545f58372117a3a131983R52
(which you agreed to on irc)

Comment 10

[Florin Strugariu [:Bebe]]

Comment on attachment 8519855 [details] [review]
Gaia PR

merged in https://github.com/mozilla-b2g/gaia/commit/1d8381bed3b1790a6db254ed5c3574959a6cccc4

Comment 11

[Florin Strugariu [:Bebe]]

Comment on attachment 8519872 [details] [review]
Credentials PR

merged in https://github.com/mozilla/webqa-credentials/commit/e90fcd8eb9bd60ec2e3490e2f45c694dec49e982

Comment 12

[Florin Strugariu [:Bebe]]

Comment on attachment 8519875 [details] [review]
Gaia PR 2.1

merged in https://github.com/mozilla-b2g/gaia/commit/ac18d6cd5c3dd350b91c720cfde478c7ed42960b

Comment 13

[Johan Lorenzo [:jlorenzo]]

Every PR has been merged.

Comment 14

[Johan Lorenzo [:jlorenzo]]

Reverted https://github.com/mozilla-b2g/gaia/commit/9a7611a74aa762bb910351fd444ea0f533ea9efd

Reason: https://github.com/mozilla-b2g/gaia/pull/25999/files#diff-5f185e0a848e4f3d959bf71b131aac66R19 "local_phone_number" is written instead of "local_phone_numbers"

Comment 15

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR - master - second try

Here's the second try with the nit fixed. Can you reland this patch, Bebe?

Comment 16

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/6c569cf6242c13610768c111963f786faa928269