Closed Bug 1094185 Opened 5 years ago Closed 5 years ago

[DSDS] Make testvars.json handle 2 SIMs

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file, 3 obsolete files)

46 bytes, text/x-github-pull-request
Bebe
: review+
Details | Review
To implement the DSDS tests, we need to update the structure of testvars.json. My first idea would be to change the key "carrier" to "carriers" and have an array of carriers like:
>    "carriers": [{
>      "phone_number": "123456789",
>      "country": "United States",
>      "network": "Carrier1"
>    },{
>      "phone_number": "987654321",
>      "country": "United States",
>      "network": "Carrier2"
>    }],

This change would imply to modify the 18 occurrences in gaia-ui-tests, the credentials in webqa-credentials and the testvars.json from every person running these tests. For that I propose update the credential on 1 device in the lab and run the the entire test suite. Then, send an email to gaia-ui-automation to tell people to update their file.


Another modification could be to add a new key called "dsds" and put the carrier info there. No modification would be needed for the current test suite and the credential. One problem I see here is a semantic issue (same kind of data in 2 different keys).
What are your takes on this, guys?
Flags: needinfo?(zcampbell)
Flags: needinfo?(gmealer)
Flags: needinfo?(florin.strugariu)
As we have the IMEI as a list. I would like to continue using the same syntax. I don't think we will have any big issues updating our local testvars and test files
Flags: needinfo?(florin.strugariu)
It seems OK to me.
The country and carrier I originally added for marketplace payment testing and it's not used AFAIK. The carrier can on the rare occasion be useful sometimes if there's different behaviour between carriers' SIMs.

IMO You can remove it unless you think there's a reason we'll need it again in the future.
Flags: needinfo?(zcampbell)
Assignee: nobody → jlorenzo
QA Whiteboard: [fxosqa-auto-s3][fxosqa-auto-points=3]
Attached file Gaia PR (obsolete) —
21 occurrences of "testvars['carrier']" found for now.
Flags: needinfo?(gmealer)
Attachment #8519855 - Flags: review?(martijn.martijn)
Attachment #8519855 - Flags: review?(florin.strugariu)
Attached file Credentials PR (obsolete) —
Attachment #8519872 - Flags: review?(martijn.martijn)
Attachment #8519872 - Flags: review?(florin.strugariu)
Attached file Gaia PR 2.1 (obsolete) —
If we change the credentials, we would need to quickly change 2.1 as well.
Attachment #8519875 - Flags: review?(martijn.martijn)
Attachment #8519875 - Flags: review?(florin.strugariu)
Blocks: 1096268
Attachment #8519855 - Flags: review?(martijn.martijn) → review+
Like :mwargers said on IRC, it's more prudent to clean up the carrier afterwards. Let's track this in 1096268.
Attachment #8519872 - Flags: review?(martijn.martijn) → review+
Attachment #8519875 - Flags: review?(martijn.martijn) → review+
Attachment #8519875 - Flags: review?(florin.strugariu) → review+
Attachment #8519872 - Flags: review?(florin.strugariu) → review+
Attachment #8519855 - Flags: review?(florin.strugariu) → review+
Attachment #8519875 - Attachment is obsolete: true
Every PR has been merged.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Here's the second try with the nit fixed. Can you reland this patch, Bebe?
Attachment #8519993 - Flags: review?(florin.strugariu)
Attachment #8519993 - Flags: review?(florin.strugariu) → review+
Blocks: 1093608
Blocks: 1093589
Blocks: 1093585
Blocks: 1094139
You need to log in before you can comment on or make changes to this bug.