1094189 - Remove shell "resolver" function

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: remove-resolver

Doesn't seem to be used by anything.

Comment 1

[Till Schneidereit [:till]]

Comment on attachment 8517449 [details] [diff] [review]
remove-resolver

Review of attachment 8517449 [details] [diff] [review]:
-----------------------------------------------------------------

Bouncing review to jorendorff because he introduced the function and might know if it's still used (e.g. in manual testing).

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8517449 [details] [diff] [review]
remove-resolver

Review of attachment 8517449 [details] [diff] [review]:
-----------------------------------------------------------------

No, nobody uses this.

I think maybe I put it in for jsfunfuzz but nobody ever taught jsfunfuzz to use it. In any case this is such an atypical resolve hook that I don't think it's worth keeping around. Thanks for removing it.

Comment 3

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7f7a0315041

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=dc265cc31095 since one of this changes caused i guess https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3630077&repo=mozilla-inbound

Comment 5

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f9f2da856e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a1f9f2da856e