1094317 - (ios) Settings page should change UI

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

Turning things on or off in the settings page should turn them on/off in the main UI.

Comment 1

[Richard Newman [:rnewman]]

I still have an outstanding invitation to UX to meet an explain some of the constraints around what "off" and "on" might mean here.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Pull request

This patch got a bit large, but the basic bits we need are in there. i.e. A data provider for Panels, and the ability to modify the order/enabled state using it. Happy to discuss changes in the PR.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8521775 [details] [review]
Pull request

Lots of nits and style fixes, but also some questions.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Pull request

Updated for review comments. I haven't removed all the coupling. I'd love to see some pseudo-code describing what you want there in a bit more detail st3fan.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I'm wondering if we should still include this. I hate to throw away good code but it seems that UX is taking a completely different direction, getting rid of the whole tabbar. Which probably means we have to undo a lot of the work this patch is doing.

So maybe we should keep things basic and as the way they are now in the app and wait until the direction is more clear?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Indeed, the Settings UI is currently conflated between two things:
1. Showing UI
2. Controlling Sync

I think #2 is more important any way. If this bug is all about #1 and a different bug exists for #2, lets just hold off on this bug (or close it soon).

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Is that UI actually controlling sync? Ie, turning off passwords will turn off password syncing on all your devices?

Or is just telling *this app* what to sync and display?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Stefan Arentz [:st3fan] from comment #7)
> Is that UI actually controlling sync? Ie, turning off passwords will turn
> off password syncing on all your devices?

Yes. This is how Sync works, and why we'd like to change it.

> Or is just telling *this app* what to sync and display?

No. This is how we'd like Sync to work, but it doesn't.

Comment 9

[Wesley Johnston (:wesj)]

Merged this.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8524345 [details] [review]
Pull request

Sorry I forgot to r+ this when I reviewed it.