1094430 - Cannot login to FxA on -dev using 1.1 (or FF18)

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[[e-mail]]

STR: 

  Login with FF18 on -dev.

What happens:

  Login window is dismissed but the login fails to complete

What should happen.

  Login completes successfully and the page is updated to show you are signed in.

The initial bug to fix why the login doesn't work in FF18 and FFOS 1.1 was fixed here 1093747

As we were working-around the lack of window.location.origin pre Gecko21 elsewhere changes were made to move to using a polyfill.

This caused this bug due to polyfill not being required in settings_local. 

You can see this by running require('settings'); in the console.

the Fix for this has been landed but the code doesn't appear to be deployed on -dev. Looking at  https://marketplace-dev-cdn.allizom.org/media/fireplace/js/include.js?b=1415213857181 there are only 2 strings matching 'polyfill' where I'm expecting 3. 

See also:

define("settings_local",[],function(){var e=window.location.origin;return{api_url:e,media_url:document.body.getAttribute("data-media"),iframe_installer_src:e+"/iframe-install.html",iframe_potatolytics_src:e+"/potatolytics.html",potatolytics_enabled:!1,tracking_enabled:!0}})

That first array should contain 'polyfill'.

The patch was landed here: 

https://github.com/mozilla/fireplace/commit/453fff28efe999a6438cd8eb5086f6b16fb161e2

Once the deployment issue is resolved this should work.

Comment 1

[[e-mail]]

Tested this after a subsequent rev was deployed and it's working now.

Comment 2

[[e-mail]]

Additional QA notes - you can use FFOS 1.1 or FF18 on -dev to test this.

Comment 3

[krupa raj[:krupa]]

verified fixed at https://www.dropbox.com/s/236hgv6hojo6c8k/Screenshot%202014-11-10%2019.07.17.png?dl=0