1094434 - resizer (e.g. on textarea) needs to be drawn in RTL form when writing-mode is vertical-rl

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Jonathan Kew (:jfkthame)]

Currently, the rendering of a resizer is sensitive to direction (LTR vs RTL), so that when it appears at the bottom-left of a (horizontal) RTL textarea, it renders mirrored from the bottom-right version. But on a vertical-rl textarea, although it appears at the bottom left, it still renders as it would at the bottom right.

In vertical writing-mode, the rendering of the resizer should depend on the block direction instead of the inline direction, so that instead of LTR vs RTL, it will depend on vertical-lr vs vertical-rl.

Comment 1

[Jonathan Kew (:jfkthame)]

Attachment: Render resizer appropriately for vertical-lr and vertical-rl writing modes.

This was a bit confusing, as the rendering of the resizer is handled completely differently when scrollbars are present vs when they're absent. But AFAICT this appears to work properly in either case. (Only tested on OS X so far, in conjuction with a bunch of other pending vertical-mode patches.)

Comment 2

[Jonathan Kew (:jfkthame)]

Attachment: Reftests for display of resizer on vertical-lr and vertical-rl textareas.

Reftest to go with this.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8517735 [details] [diff] [review]
Reftests for display of resizer on vertical-lr and vertical-rl textareas.

Review of attachment 8517735 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/writing-mode/1094434-1-ref.html
@@ +12,5 @@
> +  writing-mode: vertical-lr;
> +}
> +.vrl {
> +  writing-mode: vertical-rl;
> +}

Remove these unused classes

Comment 4

[Jonathan Kew (:jfkthame)]

It turns out this fails on Linux, but that's because RTL resizer rendering is broken there already. I've filed bug 1094845 about that.

Comment 5

[Jonathan Kew (:jfkthame)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e36492ae23a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/13167bb74be0

Comment 6

[Carsten Book [:Tomcat]]

sorry had to backout for Android Test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3850318&repo=mozilla-inbound

Comment 7

[Jonathan Kew (:jfkthame)]

Argh. Yes, that's clearly been caused by the patch here. (Guess I didn't tryserver enough platforms!) :( I'll look into it.

Comment 8

[Jonathan Kew (:jfkthame)]

Relanded; tryserver says this should be OK now.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1f402f29fcb7

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a65cacf8a37
https://hg.mozilla.org/integration/mozilla-inbound/rev/9772eacfaf03

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a65cacf8a37
https://hg.mozilla.org/mozilla-central/rev/9772eacfaf03