Closed
Bug 1094434
Opened 11 years ago
Closed 11 years ago
resizer (e.g. on textarea) needs to be drawn in RTL form when writing-mode is vertical-rl
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
3.67 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
3.60 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Currently, the rendering of a resizer is sensitive to direction (LTR vs RTL), so that when it appears at the bottom-left of a (horizontal) RTL textarea, it renders mirrored from the bottom-right version. But on a vertical-rl textarea, although it appears at the bottom left, it still renders as it would at the bottom right.
In vertical writing-mode, the rendering of the resizer should depend on the block direction instead of the inline direction, so that instead of LTR vs RTL, it will depend on vertical-lr vs vertical-rl.
Assignee | ||
Comment 1•11 years ago
|
||
This was a bit confusing, as the rendering of the resizer is handled completely differently when scrollbars are present vs when they're absent. But AFAICT this appears to work properly in either case. (Only tested on OS X so far, in conjuction with a bunch of other pending vertical-mode patches.)
Attachment #8517734 -
Flags: review?(roc)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Reftest to go with this.
Attachment #8517735 -
Flags: review?(roc)
Attachment #8517734 -
Flags: review?(roc) → review+
Comment on attachment 8517735 [details] [diff] [review]
Reftests for display of resizer on vertical-lr and vertical-rl textareas.
Review of attachment 8517735 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/reftests/writing-mode/1094434-1-ref.html
@@ +12,5 @@
> + writing-mode: vertical-lr;
> +}
> +.vrl {
> + writing-mode: vertical-rl;
> +}
Remove these unused classes
Attachment #8517735 -
Flags: review?(roc) → review+
Assignee | ||
Comment 4•11 years ago
|
||
It turns out this fails on Linux, but that's because RTL resizer rendering is broken there already. I've filed bug 1094845 about that.
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e36492ae23a6
https://hg.mozilla.org/integration/mozilla-inbound/rev/13167bb74be0
Target Milestone: --- → mozilla36
Comment 6•11 years ago
|
||
sorry had to backout for Android Test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3850318&repo=mozilla-inbound
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 7•11 years ago
|
||
Argh. Yes, that's clearly been caused by the patch here. (Guess I didn't tryserver enough platforms!) :( I'll look into it.
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 8•11 years ago
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a65cacf8a37
https://hg.mozilla.org/mozilla-central/rev/9772eacfaf03
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•