Closed
Bug 1094441
Opened 10 years ago
Closed 10 years ago
Enable 'css selector' strategy in chrome scope
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: ahal, Assigned: automatedtester)
References
Details
Attachments
(2 files, 1 obsolete file)
For some reason 'css selector' is not a valid strategy, only because it is explicitly blacklisted: http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2813 Afaict, document.querySelector() should work perfectly fine in chrome scope and there is no good reason we are preventing it. Let's turn it back on!
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dburns
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal Pull down this commit: hg pull review -r f1dbfa82c63ef37d2bb5c60ac5b50ada4377563c
Assignee | ||
Updated•10 years ago
|
Attachment #8524888 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 3•10 years ago
|
||
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal Pull down this commit: hg pull review -r f1dbfa82c63ef37d2bb5c60ac5b50ada4377563c
Reporter | ||
Comment 4•10 years ago
|
||
https://reviewboard.mozilla.org/r/767/#review349 ::: testing/marionette/marionette-server.js (Diff revision 1) > - this.elementManager = new ElementManager([SELECTOR, NAME, LINK_TEXT, PARTIAL_LINK_TEXT]); > + this.elementManager = new ElementManager([NAME, LINK_TEXT, PARTIAL_LINK_TEXT]); Please update the docstrings in marionette.py: http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#1316 (Note there are four locations, two each for Marionette and HTMLElement)
Assignee | ||
Comment 5•10 years ago
|
||
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal /r/771 - updating docstrings Pull down these commits: hg pull review -r ea4314a74baf7e6f22410051201758c8b89cb05a
Reporter | ||
Updated•10 years ago
|
Attachment #8524888 -
Flags: review?(ahalberstadt) → review+
Reporter | ||
Comment 6•10 years ago
|
||
https://reviewboard.mozilla.org/r/767/#review351 Ship It!
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/47faf7c36050
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47faf7c36050
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 10•9 years ago
|
||
W00t; thanks guys!
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8524888 -
Attachment is obsolete: true
Attachment #8618559 -
Flags: review+
Attachment #8618560 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•