Closed Bug 1094441 Opened 10 years ago Closed 10 years ago

Enable 'css selector' strategy in chrome scope

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: ahal, Assigned: automatedtester)

References

Details

Attachments

(2 files, 1 obsolete file)

For some reason 'css selector' is not a valid strategy, only because it is explicitly blacklisted:
http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2813

Afaict, document.querySelector() should work perfectly fine in chrome scope and there is no good reason we are preventing it. Let's turn it back on!
Assignee: nobody → dburns
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal

Pull down this commit:

hg pull review -r f1dbfa82c63ef37d2bb5c60ac5b50ada4377563c
Attachment #8524888 - Flags: review?(ahalberstadt)
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal

Pull down this commit:

hg pull review -r f1dbfa82c63ef37d2bb5c60ac5b50ada4377563c
https://reviewboard.mozilla.org/r/767/#review349

::: testing/marionette/marionette-server.js
(Diff revision 1)
> -  this.elementManager = new ElementManager([SELECTOR, NAME, LINK_TEXT, PARTIAL_LINK_TEXT]);
> +  this.elementManager = new ElementManager([NAME, LINK_TEXT, PARTIAL_LINK_TEXT]);

Please update the docstrings in marionette.py:
http://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/marionette.py#1316

(Note there are four locations, two each for Marionette and HTMLElement)
/r/769 - Bug 1094441: Allow CSS Selector as a search strategy for Marionette in Chrome context; r=ahal
/r/771 - updating docstrings

Pull down these commits:

hg pull review -r ea4314a74baf7e6f22410051201758c8b89cb05a
Attachment #8524888 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/47faf7c36050
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
W00t; thanks guys!
Attachment #8524888 - Attachment is obsolete: true
Attachment #8618559 - Flags: review+
Attachment #8618560 - Flags: review+
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.