Closed Bug 1094457 Opened 5 years ago Closed 5 years ago

Implement ReadBuffer

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(4 files, 1 obsolete file)

Attached patch 0004-Implement-ReadBuffer.patch (obsolete) — Splinter Review
No description provided.
Attachment #8517728 - Flags: review?(dvander)
Comment on attachment 8517728 [details] [diff] [review]
0004-Implement-ReadBuffer.patch

Review of attachment 8517728 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFramebuffer.cpp
@@ +935,5 @@
>      FinalizeDrawAndReadBuffers(gl, ColorAttachment(0).IsDefined());
>  }
>  
> +bool
> +WebGLFramebuffer::ValidateForRead(const char* info)

Where does this get called from?
Attachment #8517728 - Attachment is obsolete: true
Attachment #8554928 - Flags: review?(dglastonbury)
Comment on attachment 8554928 [details] [diff] [review]
0001-Implement-ReadBuffer.patch

Review of attachment 8554928 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextFramebuffers.cpp
@@ +470,5 @@
> +        if (mode != LOCAL_GL_NONE &&
> +            !isColorAttachment)
> +        {
> +            ErrorInvalidEnumInfo("readBuffer: If READ_FRAMEBUFFER is non-null,"
> +                                 " `mode` must be COLOR_ATTACHMENTN or NONE."

Typo? COLOR_ATTACHMENTN or do you mean COLOR_ATTACHMENTn? (Eg. COLOR_ATTACHMENT0)
Attachment #8554928 - Flags: review?(dglastonbury) → review+
Attachment #8554929 - Flags: review?(dglastonbury) → review+
Attached patch 0003-fixes.patchSplinter Review
Attachment #8563795 - Flags: review?(dglastonbury)
Attachment #8563795 - Flags: review?(dglastonbury) → review+
This is failing on Android because querying MAX_SAMPLES in INVALID_ENUM on our Android slaves.

From this Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29abb388a944
https://hg.mozilla.org/mozilla-central/rev/688f46924277
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.