109450 - Move sidebar string to sidebarOverlay.dtd to prevent brand.dtd loading

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P2)

Description

[Blake Ross]

The data in bug 109207 shows brand.dtd loading 6 times on startup. I've fixed 3
of the times.  Moving the sidebarName string from brand.dtd to
sidebarOverlay.dtd (where it belongs) would fix a fourth; we have to load
sidebarOverlay.dtd anyways. I would fix this myself but it's going to require
changes in the commercial tree.

Comment 1

[Samir Gehani]

Yup, noticed that in a recent MOZ_TIMELINE log.

Comment 2

[Samir Gehani]

Bugscape 11007 covers the commercial side of this bug.

Comment 3

[Samir Gehani]

Attachment: Inline sidebarName (former dtd entity).

Comment 4

[Samir Gehani]

morse, please r.
blake, please sr.

Comment 5

[Stephen P. Morse]

Comment on attachment 58124 [details] [diff] [review]
Inline sidebarName (former dtd entity).

r=morse

Comment 6

[Samir Gehani]

dveditz, please sr.

Comment 7

[Blake Ross]

So commercial has its own sidebarOverlay.dtd?  I was suggesting to move the
entity into the file, not remove the external entity reference altogether.

Anyways, assuming comm. has its own that keeps it My Sidebar, shouldn't the S in

The Sidebar is currently empty.

be lowercase?

Other than that, sr=blake

Comment 8

[Samir Gehani]

> So commercial has its own sidebarOverlay.dtd?  I was suggesting to move the
> entity into the file, not remove the external entity reference altogether.

If we don't remove the reference to brand.dtd won't it load anyways?  If I've
misunderstood please elaborate.  Thanks.

Comment 9

[Samir Gehani]

Attachment: Revised patch with case change.

Comment 10

[Samir Gehani]

Checked in.

Comment 11

[sujay]

Blake, please verify and mark verified-fixed....thanks

Comment 12

[sujay]

verified.