1094510 - e10s - browser_canonizeURL.js hits the network if enabled in e10s

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b60e6638f1c6

... and crashes everywhere. Very sad. Needs e10s love. Not sure why this is breaking on e10s and nowhere else, but there we are.

Looks like:

10:27:43 INFO - 293 INFO TEST-START | chrome://mochitests/content/browser/browser/base/content/test/general/browser_canonizeURL.js
10:27:43 INFO - FATAL ERROR: Non-local network connections are disabled and a connection attempt to www.example.net (93.184.216.119) was made.
10:27:43 INFO - You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
10:27:45 INFO - ###!!! [Child][MessageChannel::SendAndWait] Error: Channel error: cannot send/recv
10:27:45 INFO - TEST-INFO | Main app process: killed by SIGHUP
10:27:45 INFO - 294 INFO checking window state
10:27:45 INFO - 295 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_canonizeURL.js | entering 'example' loads expected URL
10:27:45 INFO - 296 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_canonizeURL.js | application terminated with exit code 1

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1094510 - make browser_canonizeURL.js not hit the network in e10s mode, r?mconley

Review commit: https://reviewboard.mozilla.org/r/37123/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37123/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8724711 [details]
MozReview Request: Bug 1094510 - make browser_canonizeURL.js not hit the network in e10s mode, r?mconley

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37123/diff/1-2/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8724711 [details]
MozReview Request: Bug 1094510 - make browser_canonizeURL.js not hit the network in e10s mode, r?mconley

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37123/diff/2-3/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8724711 [details]
MozReview Request: Bug 1094510 - make browser_canonizeURL.js not hit the network in e10s mode, r?mconley

https://reviewboard.mozilla.org/r/37123/#review33695

This looks fine - thanks for the handy utility function!

::: browser/base/content/test/general/browser_canonizeURL.js:53
(Diff revision 3)
> +          sendAsyncMessage("browser_canonizeURL:start");

Can you add some quick documentation here about why we're going to send this off to trigger the continuation of part of the test?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5bfead86cc6c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5bfead86cc6c