1094519 - Advertise h2-15 in parallel with h2-14

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[u408661]

These are effectively the same bits on the wire (modulo one error code that was added in h2-15, but doesn't have significant impact on operation of h2-14), so we should contemplate advertising both to maximize testing potential (in case one of the server sides decides to start advertising -15 exclusively).

If we do this, we should either advertise both or neither, but never just one and not the other (in other words, they're both gated on network.spdy.enabled.http2draft, not separate prefs like the ability to advertise h2).

Comment 1

[u408661]

Patrick - does this seem like a reasonable course to you?

Comment 2

[Patrick McManus [:mcmanus]]

i'm pretty torn. I'm leaning towards just leaving draft-14 to the dustbin.

let's survey the server side folks at the ietf meeting.

Comment 3

[u408661]

Sounds good. I've got patches ready for either eventuality (advertising exclusively h2-15, and advertising both h2-15 and h2-14) that pass tests locally. I'm going to upload them both, and once we figure this out next week, I'll mark one for review.

Comment 4

[u408661]

Attachment: patch to advertise both h2-14 and h2-15

Comment 5

[u408661]

Attachment: patch to advertise h2-15 exclusively

Comment 6

[Patrick McManus [:mcmanus]]

Comment on attachment 8518471 [details] [diff] [review]
patch to advertise both h2-14 and h2-15

Review of attachment 8518471 [details] [diff] [review]:
-----------------------------------------------------------------

talking with some big servers today I've gotten feedback that -14 is marked as an implementation draft and -15 is not, so they will be sticking with -14 until we transition to pure h2 - at least on the main servers. msft has indicated that they will make an end point with http_1_1_required available for us to test against - it might require -15 s let's go with both as this patch does.

thanks nick

::: netwerk/protocol/http/nsHttp.h
@@ +38,5 @@
>          // 26 was http/2-draft08 and http/2-draft07 (they were the same)
>          // 27 was http/2-draft09, h2-10, and h2-11
>          // 28 was http/2-draft12
>          // 29 was http/2-draft13
> +        HTTP2_VERSION_DRAFT15 = 30

comment about history of 14 and 15

Comment 7

[u408661]

Attachment: patch to advertise both h2-14 and h2-15 v1.1

Updated with comment Pat wanted for checkin.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3ae9b1a8c8b5

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f834ea8920b1

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f834ea8920b1