Closed Bug 1094560 Opened 6 years ago Closed 6 years ago

Use m-c recurse.mk instead of a clone

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 36.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: jcranmer, Assigned: jcranmer)

Details

Attachments

(1 file, 1 obsolete file)

The easier way to port bug 1094033 is to not keep a clone of this file and include the m-c file directly. The file can't be removed altogether since MOZILLA_DIR is defined while this file is included, so I can't change moz.build to include $(MOZILLA_DIR)/config/recurse.mk instead.
Attachment #8517870 - Flags: review?(mh+mozilla)
/r/191 - Bug 1094560 - Eliminate the clone of config/recurse.mk in comm-central, r=glandium

Pull down this commit:

hg pull review -r bc00bfcb39a60293fe4ff27ab8e4ad4ed93319df
https://reviewboard.mozilla.org/r/191/#review95

::: config/rules.mk
(Diff revision 1)
> -endif

So this change is part of the port of bug 1094033 itself, so this patch doesn't work unless bug 1094033 is in mozilla-central (well, more specifically, make package appears to crash and burn).
Attachment #8517870 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/a162396c7876
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Attachment #8517870 - Attachment is obsolete: true
Attachment #8618561 - Flags: review+
You need to log in before you can comment on or make changes to this bug.