1094560 - Use m-c recurse.mk instead of a clone

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

The easier way to port bug 1094033 is to not keep a clone of this file and include the m-c file directly. The file can't be removed altogether since MOZILLA_DIR is defined while this file is included, so I can't change moz.build to include $(MOZILLA_DIR)/config/recurse.mk instead.

Comment 1

[Joshua Cranmer [:jcranmer]]

Attachment: MozReview Request: bz://1094560/jcranmer

Comment 2

[Joshua Cranmer [:jcranmer]]

/r/191 - Bug 1094560 - Eliminate the clone of config/recurse.mk in comm-central, r=glandium

Pull down this commit:

hg pull review -r bc00bfcb39a60293fe4ff27ab8e4ad4ed93319df

Comment 3

[Joshua Cranmer [:jcranmer]]

https://reviewboard.mozilla.org/r/191/#review95

::: config/rules.mk
(Diff revision 1)
> -endif

So this change is part of the port of bug 1094033 itself, so this patch doesn't work unless bug 1094033 is in mozilla-central (well, more specifically, make package appears to crash and burn).

Comment 4

[Mike Hommey [:glandium]]

https://reviewboard.mozilla.org/r/189/#review99

Ship It!

Comment 5

[Joshua Cranmer [:jcranmer]]

https://hg.mozilla.org/comm-central/rev/a162396c7876

Comment 7

[Joshua Cranmer [:jcranmer]]

Attachment: MozReview Request: Bug 1094560 - Eliminate the clone of config/recurse.mk in comm-central, r=glandium