1094566 - webapprt's application.ini.h gets regenerated after profiling run

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

If I try to use PGOPTIMIZE instead of PGUPDATE, the linker complains:
46:06.59 webapprt.obj : fatal error LNK1270: invalid file; timestamp does not match file linked with /LTCG:PGINSTRUMENT

Comment 1

[Mike Hommey [:glandium]]

Attachment: Do not overwrite buildid on the compilation phase of PGO builds

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92503c3d379b

Comment 3

[Carsten Book [:Tomcat]]

sorry had to back this out since this was breaking linux pgo builds like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3679965&repo=mozilla-inbound

Comment 4

[Mike Hommey [:glandium]]

Damn, that's because maybe_clobber_profiledbuild actually removes a lot of stuff, including buildid :(

Comment 5

[Mike Hommey [:glandium]]

(on linux, that is)

Comment 6

[(not currently active) Ted Mielczarek]

Could you rewrite this like:
ifndef MOZ_PROFILE_USE
buildid: FORCE
endif
buildid:
...

Comment 7

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Could you rewrite this like:
> ifndef MOZ_PROFILE_USE
> buildid: FORCE
> endif
> buildid:
> ...

That would not fix the problem, since buildid would still be recreated, since it's removed. I think the best course of action is to change maybe_clobber_profiledbuild to not remove so much stuff. Or, simpler short-term fix, remove buildid from GARBAGE. It's not like make clean really works anyways.

Comment 8

[(Away)]

My make skills are weak, so please tell me what I'm missing here: Can we not provide a recipe to create buildid whenever it's missing? On Windows, it's not removed, so it wouldn't be re-created, right?

Comment 9

[(Away)]

(I admit the previous comment is Windows-centric. Just trying to get unblocked. Ideally we wouldn't do unnecessary work on any platform.)

Comment 10

[Mike Hommey [:glandium]]

Attachment: Do not overwrite buildid on the compilation phase of PGO builds

Comment 11

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f22581e2c9e5

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f22581e2c9e5