Closed Bug 1094566 Opened 5 years ago Closed 5 years ago

webapprt's application.ini.h gets regenerated after profiling run

Categories

(Firefox Build System :: General, defect)

36 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: dmajor, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

If I try to use PGOPTIMIZE instead of PGUPDATE, the linker complains:
46:06.59 webapprt.obj : fatal error LNK1270: invalid file; timestamp does not match file linked with /LTCG:PGINSTRUMENT
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Attachment #8517881 - Flags: review?(mshal) → review+
Blocks: 1095103
sorry had to back this out since this was breaking linux pgo builds like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3679965&repo=mozilla-inbound
Damn, that's because maybe_clobber_profiledbuild actually removes a lot of stuff, including buildid :(
(on linux, that is)
Could you rewrite this like:
ifndef MOZ_PROFILE_USE
buildid: FORCE
endif
buildid:
...
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Could you rewrite this like:
> ifndef MOZ_PROFILE_USE
> buildid: FORCE
> endif
> buildid:
> ...

That would not fix the problem, since buildid would still be recreated, since it's removed. I think the best course of action is to change maybe_clobber_profiledbuild to not remove so much stuff. Or, simpler short-term fix, remove buildid from GARBAGE. It's not like make clean really works anyways.
My make skills are weak, so please tell me what I'm missing here: Can we not provide a recipe to create buildid whenever it's missing? On Windows, it's not removed, so it wouldn't be re-created, right?
(I admit the previous comment is Windows-centric. Just trying to get unblocked. Ideally we wouldn't do unnecessary work on any platform.)
Attachment #8517881 - Attachment is obsolete: true
Attachment #8527995 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/f22581e2c9e5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.