1094754 - Please re-deploy Loop-Client 0.9.0 code to stage with the new nginx configuration.

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Alexis Metaireau (:alexis)]

We'd like to re-deploy the loop-client 0.9.0 release to stage, with a new configuration that's at 

https://github.com/mozilla/loop-client/releases/tag/0.9.0

This mainly needs a configuration change which is tracked at Bug 1089657.

Comment 1

[Bob Micheletto [:bobm]]

Stack updated with new Nginx configuration.  Closing ticket.

Comment 2

[Mark Banner (:standard8)]

Either the nginx configuration hasn't changed, or it isn't working.

https://call.stage.mozaws.net/c/9nN-3amSXL8 is giving 404, whereas it should be giving something similar to https://call.stage.mozaws.net/#call/9nN-3amSXL8

Comment 3

[Mark Banner (:standard8)]

https://call.stage.mozaws.net/2UV1FviKq2g should also at least be giving the index page.

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

mostlygeek -
Thanks for getting this redeployed. the fix to the nginx config appears to be working now

Running through stage verification and quick checks, everything looks good except:
https://call.stage.mozaws.net/legal/terms/
Which pulls up a blank page

Could you look into that?

Comment 5

[Rémy Hubscher (:natim)]

> https://call.stage.mozaws.net/legal/terms/

Yes it seems that we need to define a rule for this.

We have two issues here:

 - https://call.stage.mozaws.net/legal/terms/ should load https://call.stage.mozaws.net/legal/terms/index.html
 - https://call.stage.mozaws.net/legal/terms/something.html should returns a 404
 - https://call.stage.mozaws.net/legal/terms/en_US.html shoulod returns a 200 with the right content.

Comment 6

[Benson Wong [:mostlygeek]]

I have a new nginx configuration: https://github.com/mozilla-services/puppet-config/pull/987

It loads what's expected for: 

- https://call.stage.mozaws.net/ = /index.html
- https://call.stage.mozaws.net/{token} = /index.html
- https://call.stage.mozaws.net/c/{token} = /index.html
- https://call.stage.mozaws.net/js/wrong-file.js = 404
- https://call.stage.mozaws.net/js/webapp.js = 200 (correct file)
- https://call.stage.mozaws.net/config.js = 200 correct file
- https://call.stage.mozaws.net/c/config.js = 200 correct file
- https://call.stage.mozaws.net/legal/terms/ = 200 correct file, also ajax works
- https://call.stage.mozaws.net/legal/terms = 301 - known issue, fix later.

Comment 7

[Richard Pappalardo [:rpapa][:rpappalardo]]

Thanks, Benson.  I'll do some quick checks

------------------
RELEASE NOTES
------------------

https://github.com/mozilla/loop-client/releases
https://github.com/mozilla/loop-client/compare/0.6.1...0.7.0
https://github.com/mozilla/loop-client/compare/0.7.0...0.8.0
https://github.com/mozilla/loop-client/compare/0.8.0...0.9.0

TAG
https://github.com/mozilla/loop-client/releases/tag/0.9.0

CONFIG CHANGES: 
Loop Server 0.13 configuration changes. 
https://github.com/mozilla-services/puppet-config/blob/master/loop/yaml/app/loop_server.dev.yaml
https://github.com/mozilla-services/puppet-config/blob/master/loop/yaml/app/loop_server.prod.yaml
https://github.com/mozilla-services/puppet-config/blob/master/loop/yaml/app/loop_server.stage.yaml
https://github.com/mozilla-services/puppet-config/blob/master/loop/yaml/app/loop_server.yaml

Adding settings required for the 0.9.0 release 
https://github.com/mozilla-services/puppet-config/blob/master/loop/modules/loop_client/templates/client_config.js

Fix loop-client nginx rules for 0.9.0's new endpoints 
https://github.com/mozilla-services/puppet-config/blob/master/loop/modules/loop_client/templates/openresty.conf.erb

revise nginx config for loop-client
https://github.com/mozilla-services/puppet-config/pull/987

[12:56]  mostlygee: rpapa: the other thing I want to mention is x-token-match header I put in
[12:56]  mostlygeek: if you see that header it means nginx used the token match regex to serve the file

Comment 8

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
STAGE VERIFICATION
------------------

STAGE STACK:
$ rpm -qa | grep loop
puppet-config-loop 20141112234505-1 x86_64 16770
loop-client-svcops 0.9.0-1 x86_64 11882108

$ cat /data/loop-client/content/VERSION.txt
0.9.0
66e289a80c8792f8afcab09708e9fe2bc9e7b44f Thu, 23 Oct 2014 21:41:22 +0100

 rpm -qa |grep loop
puppet-config-loop 20141112234505-1 x86_64 16770
loop-client-svcops 0.9.0-1 x86_64 11882108

/data/loop-client/content/VERSION.txt:
0.9.0
66e289a80c8792f8afcab09708e9fe2bc9e7b44f Thu, 23 Oct 2014 21:41:22 +0100

PROCESSES RUNNING:
stackdriver, nginx, python, circus, heka  

/opt:
aws  ec2  openresty  rh  stackdriver

/data:
hekad  loop-client

/etc:
heka.d
heka.d/loop-client.toml

/etc/puppet/yaml/app:
loop_client.dev.yaml  
loop_client.prod.yaml 
loop_client.stage.yaml  
loop_client.yaml  
loop_server.dev.yaml  
loop_server.prod.yaml  
loop_server.stage.yaml  
loop_server.yaml

LOGS:
/var/log/circus.log
/var/log/hekad
/media/ephemeral0/nginx/logs 

------------------
QUICK CHECKS
------------------
https://call.stage.mozaws.net/VERSION.txt
0.9.0
66e289a80c8792f8afcab09708e9fe2bc9e7b44f Thu, 23 Oct 2014 21:41:22 +0100

https://call.stage.mozaws.net/config.js:
var loop = loop || {};

loop.config = {
  serverUrl: 'https://loop.stage.mozaws.net',
  feedbackApiUrl: 'https://input.allizom.org/api/v1/feedback',
  feedbackProductName: 'Loop',
  brandWebsiteUrl: 'https://www.mozilla.org/firefox/',
  privacyWebsiteUrl: 'https://www.mozilla.org/privacy',
  legalWebsiteUrl: '/legal/terms/',
  marketplaceUrl: 'https://marketplace.firefox.com/iframe-install.html',
  fxosApp: {
    name: 'Firefox Hello',
    manifestUrl: 'https://marketplace.firefox.com/app/54b83aea-1208-4605-82eb-22819f39d81d/manifest.webapp'
  }
};

https://call.stage.mozaws.net/:
Welcome to the Firefox Hello web client.

$ curl -I https://call.stage.mozaws.net
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-length: 2499
Content-Type: text/html
Date: Thu, 13 Nov 2014 21:54:06 GMT
ETag: "54496a7b-9c3"
Last-Modified: Thu, 23 Oct 2014 20:52:11 GMT
Vary: Accept-Encoding
X-Token-Match: 1
Connection: keep-alive

https://loop.stage.mozaws.net/:
{"name":"mozilla-loop-server","description":"The Mozilla Loop (WebRTC App) server","version":"0.13.0","homepage":"https://github.com/mozilla-services/loop-server/","endpoint":"https://loop.stage.mozaws.net","fakeTokBox":false,"fxaOAuth":true,"i18n":{"defaultLang":"en-US","lang":"en-US"}}

$ cat /etc/puppet/yaml/app/loop_client.stage.yaml
classes_hash:
    yum::repos::mozilla_services_aws_stage: true

loop_client::app_server_url: "https://loop.stage.mozaws.net"
loop_client::feedback_api_url: "https://input.allizom.org/api/v1/feedback"

https://call.stage.mozaws.net/legal/terms/:
WORKS!

https://call.stage.mozaws.net/legal/terms: (no trailing slash)
This pulls up a blank page - known issue!

Comment 9

[Richard Pappalardo [:rpapa][:rpappalardo]]

ready for prod