Closed
Bug 1094772
Opened 10 years ago
Closed 10 years ago
[pl] Update Wikipedia searchplugin for mobile
Categories
(Mozilla Localizations :: pl / Polish, defect)
Mozilla Localizations
pl / Polish
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
3.88 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
* Using the same structure of en-US * Added search activity section * Switched to https Desktop is already update, this locale is the last one missing to fix bug 1069123
Assignee | ||
Comment 1•10 years ago
|
||
Stefan, can you take a look? We need this on Aurora and Central to fix bug 1069123.
Attachment #8518113 -
Flags: review?(splewako)
Comment 2•10 years ago
|
||
Comment on attachment 8518113 [details] [diff] [review] pl_wikipedia.patch Review of attachment 8518113 [details] [diff] [review]: ----------------------------------------------------------------- I understand that Sara is not responsive but I didn't track mobile story at all and don't even have Android device to test it… and I see some unrelated to bug 1069123 changes (description removal, search activity section addition). Maybe Gandalf would be better person to review this?
Attachment #8518113 -
Flags: review?(splewako) → review?(gandalf)
Assignee | ||
Comment 3•10 years ago
|
||
As explained in comment 0 this makes all mobile searchplugins using the same structure across locales. I actually did it also for desktop, leaving alone pl since it's just been updated and has all the needed parameters. * description is not used, and it's not usually present on mobile (it is on older searchplugins). * search activity has been added in bug 1063193 for en-US. Given that I had to go through all locales, I'm fixing that too.
Comment 4•10 years ago
|
||
Comment on attachment 8518113 [details] [diff] [review] pl_wikipedia.patch Review of attachment 8518113 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8518113 -
Flags: review?(gandalf) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Stefan, do you prefer to land this dreictly? Not sure how you usually work in terms of landing, merging, etc. As said, it doesn't need to land on beta, just aurora and central.
Comment 6•10 years ago
|
||
No matter who will land - just don't merge anything please (no need) - I can do this later today if no one else will.
Assignee | ||
Comment 7•10 years ago
|
||
OK, I'll you guys manage the landings.
Assignee | ||
Comment 8•10 years ago
|
||
Landed on mozilla-aurora and l10n-central (no merge) since we're heading towards the end of the cycle http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/496391a60c3e http://hg.mozilla.org/l10n-central/pl/rev/96d2add10227
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•