1094779 - [camera] Unable to record videos if tmp.3gp exists in target video directory

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Wilson Page [:wilsonpage]]

STEPS

1. Rename one of the video files in the current video directory inside /DCIM (eg. DCIM/MZLA*/tmp.3pg)
2. Attempt to take a video

RESULT

Video recording fails because tmp.3pg can't be overwritten.

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

FIX

This patch will attempt to delete the .tmp.3pg file if the .addNamed() request fails. If that delete call fails then we give up.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Do we want to be blindly deleting video files? Maybe I have one named tmp.3gp.

Wouldn't it be better to add a number? e.g. tmp1.3gp, tmp2.3gp, etc?

Comment 3

[Justin D'Arcangelo [:justindarc]]

(In reply to Mike Habicher [:mikeh] from comment #2)
> Do we want to be blindly deleting video files? Maybe I have one named
> tmp.3gp.
> 
> Wouldn't it be better to add a number? e.g. tmp1.3gp, tmp2.3gp, etc?

This patch changes it to a hidden ".tmp.3gp" which should make it much less likely. It may not be a bad idea to use a number though.

Comment 4

[Wilson Page [:wilsonpage]]

(In reply to Mike Habicher [:mikeh] from comment #2)
> Do we want to be blindly deleting video files? Maybe I have one named
> tmp.3gp.
> 
> Wouldn't it be better to add a number? e.g. tmp1.3gp, tmp2.3gp, etc?

I thought about using a timestamp in the filename but I thought it might be nice to make sure all our tmp.3gp files were cleaned up should for some reason they not be deleted. As Justin commented, I did change to make the file file hidden.

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8518116 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/28a68f7c2b8371bd9c508289a12215b8b738958d