[Rooms] Do we want to handle the channel selection for rooms

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rhubscher, Assigned: rhubscher)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [loop-server 0.15.0])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
In the Architecture/Rooms development we never spoke about TokBox channels selection. Also it makes sense to, at least, ask the question. Do we need to let choose the TokBox channel ?

The only place we can apply this selection is on the Room creation (POST /rooms)

We could add a channel parameter as for POST /calls and POST /calls/:token
(Assignee)

Comment 1

4 years ago
Adam — Does this make sense to add this parameter?
Flags: needinfo?(adam)

Comment 2

4 years ago
Sorry for the slow response here; I've been traveling the past few weeks.

Rémy: your proposal here sounds reasonable, given the constraint that we need to specify the API key when the room is created. If you could update the docs to reflect your proposal, I'd appreciate it. Thanks!
Flags: needinfo?(adam)
(Assignee)

Comment 3

4 years ago
Created attachment 8543987 [details] [review]
Link to GitHub PR.
Attachment #8543987 - Flags: review?(alexis+bugs)
Attachment #8543987 - Flags: feedback?(mathieu)
Attachment #8543987 - Flags: feedback?(mathieu) → feedback+
(Assignee)

Comment 4

4 years ago
Created attachment 8544443 [details] [review]
Link to GitHub Documentation PR.
Attachment #8544443 - Flags: review?(alexis+bugs)
Assignee: nobody → rhubscher
Status: NEW → ASSIGNED
Comment on attachment 8544443 [details] [review]
Link to GitHub Documentation PR.

Documentation looks good to me; Waiting on changes of some code before merging everything.
Attachment #8544443 - Flags: review?(alexis+bugs) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [loop-server 0.15.0]
You need to log in before you can comment on or make changes to this bug.