1094852 - [Rooms] Do we want to handle the channel selection for rooms

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Rémy Hubscher (:natim)]

In the Architecture/Rooms development we never spoke about TokBox channels selection. Also it makes sense to, at least, ask the question. Do we need to let choose the TokBox channel ?

The only place we can apply this selection is on the Room creation (POST /rooms)

We could add a channel parameter as for POST /calls and POST /calls/:token

Comment 1

[Rémy Hubscher (:natim)]

Adam — Does this make sense to add this parameter?

Comment 2

[Adam Roach [:abr]]

Sorry for the slow response here; I've been traveling the past few weeks.

Rémy: your proposal here sounds reasonable, given the constraint that we need to specify the API key when the room is created. If you could update the docs to reflect your proposal, I'd appreciate it. Thanks!

Comment 3

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub PR.

Comment 4

[Rémy Hubscher (:natim)]

Attachment: Link to GitHub Documentation PR.

Comment 5

[Alexis Metaireau (:alexis)]

Comment on attachment 8544443 [details] [review]
Link to GitHub Documentation PR.

Documentation looks good to me; Waiting on changes of some code before merging everything.

Comment 6

[Alexis Metaireau (:alexis)]

Comment on attachment 8543987 [details] [review]
Link to GitHub PR.

This is now in master. https://github.com/mozilla-services/loop-server/commit/2c7d217c6247bf1913faf66a5c1f32d8c2be550d