1094888 - smart bookmarks creation in nsBrowserGlue should use the new Bookmarks.jsm API

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we must pay attention to order of startup events, or we could break defaults import...

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

taking

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: part 1 - make it async.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: part 2 - use Bookmarks.jsm

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: part 2 (ignore whitespace changes)

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8584985 [details] [diff] [review]
part 2 (ignore whitespace changes)

Review of attachment 8584985 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for posting the patch without white space changes, that made it a lot easier to follow!

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Thank you!
https://hg.mozilla.org/integration/fx-team/rev/79b0d1c565a8
https://hg.mozilla.org/integration/fx-team/rev/46e43ff8cdb5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/79b0d1c565a8
https://hg.mozilla.org/mozilla-central/rev/46e43ff8cdb5

Comment 8

[Andrei Vaida [:avaida]]

Marco, please provide a bit of context for this fix, so that QA can verify it.

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The bug replaced the code that creates smart bookmarks (most visited, recently bookmarked, recent tags) in new profiles.
So verifying those smart bookmarks are created properly should be enough.

Comment 10

[Andrei Vaida [:avaida]]

Confirmed fixed as of Nightly 40.0a1 (2015-05-03), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. Testing was performed with and without e10s. One issue was found and filed as Bug 1161048, but it's NOT something related to this fix.