1094913 - Gotpointercapture is missing pointerType attribute

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Evgeny]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

1. Open http://www.w3c-test.org/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual.html in FF with Modern UI support (any of Modern UI or Desktop modes)
2. Click black rectangle


Actual results:

String "gotpointercapture properties for pointerType = mouse" is not displayed in the results.
event.pointerType is "" for gotpointercapture


Expected results:

Presence of "gotpointercapture properties for pointerType = mouse" string in the results.
event.pointerType should be "mouse" for gotpointercapture in this case.

Comment 1

[Maksim Lebedev]

Attachment: gotlostpc_events_type_test_ver1.diff

Tests for check pointerType attribute on got/lostpointercapture events

Comment 2

[Maksim Lebedev]

Attachment: gotlostpc_events_type_test_ver1.diff

+ Small changes

Comment 3

[Maksim Lebedev]

Attachment: gotlostpc_events_type_ver1.diff

Patch for resolving issue

Comment 4

[Maksim Lebedev]

Tests with patch: https://tbpl.mozilla.org/?tree=Try&rev=a19cd781373c

Comment 5

[Maksim Lebedev]

Test without patch: https://tbpl.mozilla.org/?tree=Try&rev=08913f4b0462
Test with patch: https://tbpl.mozilla.org/?tree=Try&rev=42a83eedf432

Comment 6

[Olli Pettay [:smaug] (away May 1 - 8)]

Comment on attachment 8519925 [details] [diff] [review]
gotlostpc_events_type_ver1.diff

>+ConvertPointerTypeToString(nsAString& aPointerTypeDest, uint16_t aPointerTypeSrc)
Please swap the order of the parameters. "outparam" should be the latter one.

>+nsIPresShell::GetPointerType(uint32_t aPointerId)
>+{
>+  PointerInfo* pointerInfo = nullptr;
>+  if (gActivePointersIds->Get(aPointerId, &pointerInfo) && pointerInfo)
>+    return pointerInfo->mPointerType;
Always use {} with 'if'

Comment 7

[Olli Pettay [:smaug] (away May 1 - 8)]

Comment on attachment 8519924 [details] [diff] [review]
gotlostpc_events_type_test_ver1.diff

>-      parent.is(test_listener,      false,  "listener shouldn't receive any events");
>+      parent.is(test_listener,      false,  "listener should not receive any events");
...

>     function finishTest() {
>-      setTimeout(function() {
>-        parent.is(test_down_got,  true,  "Part 2: pointerdown event should be received by target");
>-        parent.is(test_listener,  false, "Part 2: listener shouldn't receive any events");
>-        logger("finishTest");
>-        parent.finishTest();
>-      }, 1000);
>+      parent.is(test_down_got,  true,  "Part 2: pointerdown event should be received by target");
>+      parent.is(test_listener,  false, "Part 2: listener should not receive any events");
>+      logger("finishTest");
>+      parent.finishTest();
etc.

In general, please don't make unrelated changes. A patch should implement/fix one issue. Not several
totally unrelated ones. So in the future try to do clean ups in separate patches please.

But, ok, this should be fine.

Comment 8

[Maksim Lebedev]

Attachment: gotlostpc_events_type_ver2.diff

+ Changes: Swap order of arguments
+ Changes: Add {} to if
- Changes: Remove build issue

Comment 9

[Maksim Lebedev]

(In reply to Olli Pettay [:smaug] from comment #7)
> In general, please don't make unrelated changes. A patch should
> implement/fix one issue. Not several totally unrelated ones.
> So in the future try to do clean ups in separate patches please.
I only wanted to decrease time of current test.

Comment 10

[Maksim Lebedev]

Test without patch: https://tbpl.mozilla.org/?tree=Try&rev=29f2cf20b1f3
Test with patch: https://tbpl.mozilla.org/?tree=Try&rev=cf197d4088e1

Comment 11

[Maksim Lebedev]

If nobody have objections, please, anybody set 'checkin' flag. I have no rights for doing this.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6c474c0cdf9
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e5947b82cb

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d6c474c0cdf9
https://hg.mozilla.org/mozilla-central/rev/d8e5947b82cb