1094920 - remaining profiler test failures

Status: RESOLVED WORKSFORME

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Tom Tromey :tromey]

Once the bug 1047124 and bug 1084902 patches are applied, there are
still a few remaining profiler test failures:

3327 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_shared-front-01.js | Test timed out - expected PASS
3328 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_shared-front-01.js | Found a tab after previous test timed out: http://example.com/browser/browser/devtools/profiler/test/doc_simple-test.html - expected PASS
3329 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_shared-front-02.js | A promise chain failed to handle a rejection:  - at resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1113 - Error: Connection closed
Stack trace:
Front<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1113:23
ProfilerConnection.prototype._disconnectMiscActors@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/profiler/shared.js:150:5
ProfilerConnection.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/profiler/shared.js:119:5
ProfilerPanel.prototype.destroy<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/profiler/panel.js:64:5
ProfilerConnection.prototype._onEventNotification@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/profiler/shared.js:234:9
eventSource/aProto.emit@resource://gre/modules/devtools/dbg-client.jsm:189:9
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:919:7
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:545:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14

Comment 1

[Tom Tromey :tromey]

I also see this:

13 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_data-samples.js | This test contains no passes, no fails and no todos. Maybe it threw a silent exception? Make sure you use waitForExplicitFinish() if you need it. - expected PASS

I'm not sure if I missed this last time, or if it is new.
(Or maybe that this error was only enabled since the last time I examined
the test results...)

Comment 2

[Victor Porof [:vporof][:vp]]

No more test failures.