Closed Bug 1094933 Opened 10 years ago Closed 10 years ago

Whitelist supported products

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S8 (7Nov)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1094933_whitelist_products to KevinGrandon:master
50 bytes, text/x-github-pull-request
garndt
: review+
Details | Review 
      No description provided.
Attachment #8518251 - Flags: review?(garndt)
Comment on attachment 8518251 [details] [review]
[PullReq] KevinGrandon:bug_1094933_whitelist_products to KevinGrandon:master

LGTM
Attachment #8518251 - Flags: review?(garndt) → review+
Thanks. I also added one reference fix to the github library that I noticed was wrong when trying to fast-forward from a remote.
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Keywords: checkin-needed
Hmm, maybe some problem with the suggested reviewer logic?
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Keywords: checkin-needed
Filed bug 1095028, and added greg to the suggested reviewers for github bot for now.
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: