1094965 - move `fetch` from actors/script.js to DevToolsUtils.js

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

I need to use the same `fetch` in Fever Dream to fetch the HTML of a page, and this seems like a good utility function anyway so lets move it until our utils so everyone can access it.

Comment 1

[James Long (:jlongster)]

Attachment: 1094965.patch

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8518267 [details] [diff] [review]
1094965.patch

Review of attachment 8518267 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/DevToolsUtils.js
@@ +411,5 @@
> +/**
> + * Performs a request to load the desired URL and returns a promise.
> + *
> + * @param aURL String
> + *        The URL we will request.

While you're here, can you add an @param comment for aOptions?

Comment 3

[James Long (:jlongster)]

Attachment: 1094965.patch

sweet, done

Comment 4

[James Long (:jlongster)]

Attachment: 1094965.patch

Tests failed locally; had to import the `NetUtils` dependency as well (still lazily loads)

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8518305 [details] [diff] [review]
1094965.patch

Review of attachment 8518305 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/DevToolsUtils.js
@@ +407,5 @@
>      return temp[aSymbol || aName];
>    });
>  };
> +
> +exports.defineLazyGetter(this, "NetUtil", () => {

Why do you need to export NetUtil from this module?

Comment 6

[James Long (:jlongster)]

try is green https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f839dd1db2b1

Comment 7

[James Long (:jlongster)]

(In reply to Panos Astithas [:past] (overloaded, please needinfo) from comment #5)
> 
> Why do you need to export NetUtil from this module?

I'm not exporting it, but lazy loading it because it's required inside of `fetch`. That's how it was loaded in the other file. Not sure if it's also attaching it to the module object, and effectively exporting it? This depends on that, but I think we want to lazy load it, is there a better way?

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8518305 [details] [diff] [review]
1094965.patch

Review of attachment 8518305 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/DevToolsUtils.js
@@ +407,5 @@
>      return temp[aSymbol || aName];
>    });
>  };
> +
> +exports.defineLazyGetter(this, "NetUtil", () => {

defineLazyGetter is on exports, NetUtil is on this.

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

^ That was supposed to be a reply to Panos

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

D'oh, you are right. Please carry on.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/4c618071bb26

Comment 12

[James Long (:jlongster)]

Eddy, just want to make sure this is on the list of patches to apply to gum

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c618071bb26

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/43846f2b7e0d