Closed
Bug 1095002
Opened 10 years ago
Closed 10 years ago
Data usage limit dialog has incorrect role and unordered markup
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [NaBfT])
Attachments
(1 file)
In addition, there are a few other issues with the dialog:
1. It should have a role of dialog, not region.
2. The absolute positioning of the number entry and unit chooser at the bottom uses backward markup order.
|
Assignee | |
Comment 1•10 years ago
|
||
Generalizing this, since it is not just a first time use issue.
Summary: Usage first time use: Data usage limit dialog is not exclusively visible → Data usage limit dialog is not exclusively visible
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8518323 -
Flags: review?(salva)
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'm changing the summary of this bug to focus on the actual dialog accessibility. The visibility issues should be addressed holistically for all overlays and dialogs in another bug.
Summary: Data usage limit dialog is not exclusively visible → Data usage limit dialog has incorrect role and unordered markup
|
||
Updated•10 years ago
|
Whiteboard: [NaBfT]
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8518323 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25895
Looks great to me. Thank you!
Attachment #8518323 -
Flags: review?(salva) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•