Closed Bug 1095024 Opened 9 years ago Closed 9 years ago

Port bug 987849 to the jetpack mochitest harnesses

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

patch
2.06 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch — — Splinter Review 
This at least gets the harness running again. Actual support for fail-if is probably going to need to wait until bug 1095051 is fixed.
Attachment #8518359 - Flags: review?(jmaher)
Depends on: 1095051
Comment on attachment 8518359 [details] [diff] [review]
patch

Review of attachment 8518359 [details] [diff] [review]:
-----------------------------------------------------------------

this is out of my league, but I can sort of infer what you are doing and it makes sense!  I assume you are using all .ini manifests, right?
Attachment #8518359 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 8518359 [details] [diff] [review]
> patch
> 
> Review of attachment 8518359 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> this is out of my league, but I can sort of infer what you are doing and it
> makes sense!  I assume you are using all .ini manifests, right?

And yes, we use .ini manifests
https://hg.mozilla.org/mozilla-central/rev/8094e9f641e3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.