Closed
Bug 1095065
Opened 11 years ago
Closed 8 years ago
Remove en-US strings from HTML files
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: zbraniecki, Unassigned)
Details
Attachments
(1 file)
In an effort to make it easier to work with Gaia we want to remove en-US strings from HTML files.
Currently, we store some version of en-US strings in HTML files that are later overwritten by strings from l10n resources.
This creates unnecessary confusion and makes it easy to make a mistake for developers and not notice it (because screen appears to have the strings).
It also requires to keep updating the strings in two places which never happens and leaves us with two version of the same string which makes learning, grepping and localizing our code harder.
We may try to automatically clean the files, or let developers clean their files as they go if the automated script causes too much diff noise on parsing/serializing.
|
Reporter | |
Comment 1•11 years ago
|
||
First attempt to write a script to clean HTML files: https://github.com/zbraniecki/l10n-domwalker/tree/cleanhtml
|
|
Reporter | |
Comment 2•11 years ago
|
||
Here's an experimental pull request after using the domwalker script.
|
||
Comment 3•11 years ago
|
||
Thanks for filing this, and experimenting with the script. I'm not sure if the script is a good option at this point because it breaks some of our style guidelines. E.g, adding empty attribute strings (disabled=""), and doing weird things with some tags (<!DOCTYPE html><html><head>).
I think perhaps setting this as a standard, informing reviewers, and educating people might be the best way forward here.
|
|
Reporter | |
Comment 4•11 years ago
|
||
I totally agree that this patch is not reviewable. I may experiment more to try to reduce the noise. If I get anywhere with it, then I'll ask you to look again at this :)
|
||
Comment 5•8 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•