1095100 - Similar jobs: "Show previous jobs" should show append to the list of jobs, not replace it

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

I totally thought the "Show previous jobs" button in Similar Jobs would add in the next few previous jobs, especially since that's how the "next 10" button works.

Comment 1

[Johannes Pfrang [:johnp]]

I have a patch for that and I'll file a pull-request later.
I'll keep the wording, although it is wrong because the the treeherder-service is returning the data ordered from old to new instead of new to old, which makes us technically do a "Show next jobs" for now.

Comment 2

[Johannes Pfrang [:johnp]]

Attachment: Pull Request

Pull request for check-in.

The ordering issue is a regression from .mozilla.org to .allizom.org most likely from bug 1097090.

Comment 3

[Johannes Pfrang [:johnp]]

If the amount of jobs to load should be customizable like in the main view I'll add that feature as well.
Currently the link (which should probably have some button-styling attached to it) loads one page = 20 elements. I also didn't remove the whole pagination with $scope.page / $scope.page_size from the controller, but I can make that simpler as well.

Comment 4

[Johannes Pfrang [:johnp]]

For the styling I would add 'class="btn btn-default btn-sm"' to the button.
If we want to go without pagination we probably should change the naming from "Show previous jobs" to "Load previous jobs" or something else.

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8566872 [details] [review]
Pull Request

This looks great - thank you :-)

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/8fe84d24a08558e46f5bd0ab195f0249c88084d0
Bug 1095100 - let "Show previous jobs" append data instead of replacing it

update_similar_jobs() now resets the list on job change
get_list() now appends the new data by merging the arrays (using jQuery)

https://github.com/mozilla/treeherder-ui/commit/62721ea073ae93fe12319a0e1af863fc7ff5b842
Bug 1095100 - "Show previous jobs"-Button styling

https://github.com/mozilla/treeherder-ui/commit/93ff0ff49ef6fb8ebd8166a98fad48b4e6f58c57
Merge pull request #379 from johnp/bug-1095100-similar-jobs-append

Bug 1095100 - Let "Show previous jobs" append data instead of replacing it

Comment 7

[Ed Morley [:emorley]]

I've merged this & fingers crossed we should deploy in the next few days (though we've been saying that for a while!).

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/12ccfb36f0b26a01521b110854372a6bbdc5c6d3
Bug 1095100 - let "Show previous jobs" append data instead of replacing it

update_similar_jobs() now resets the list on job change
get_list() now appends the new data by merging the arrays (using jQuery)

https://github.com/mozilla/treeherder/commit/7996f0bf3b4a474992367750334ab6422b45129d
Bug 1095100 - "Show previous jobs"-Button styling

https://github.com/mozilla/treeherder/commit/54f3393167aca9d69a7f54a9ad73bb0240b98241
Merge pull request #379 from johnp/bug-1095100-similar-jobs-append

Bug 1095100 - Let "Show previous jobs" append data instead of replacing it