Closed Bug 1095110 Opened 10 years ago Closed 10 years ago

Harden stability by making autolander not crash for simple routes

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1095110_dont_crash to KevinGrandon:master
50 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
Don't allow autolander to crash yet for simple routes. We may want to fix this in the future, but for now since we use an in-memory store for active integrations, we should do our best to stay up. Adding a few try/catch statements in routes should do this. I'll keep the throwing behavior of the /bin files though - I think those might still be handy.
Attachment #8518430 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: