Closed Bug 1095117 Opened 8 years ago Closed 8 years ago

move ImplCycleCollection{Unlink,Traverse} specializations for nsRefPtr out of nsRefPtr.h

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

forward-declare cycle collection things in nsRefPtr.h
1.23 KB, patch
mccr8
: review+
Details | Diff | Splinter Review 
I don't particularly care where they go (new header seems like the best option?), but it seems silly to have nsRefPtr.h drag in all the cycle collection machinery all the time.  Not all clients of nsRefPtr will need these specializations, and clients that do should be forced to include whatever headers they need.
Transferring these to another header was...unsuccessful, but some forward
declarations are sufficient to untangle things (though it's possible that
unified builds are just masking problems here).
Attachment #8518986 - Flags: review?(continuation)
Assignee: nobody → nfroyd
Comment on attachment 8518986 [details] [diff] [review]
forward-declare cycle collection things in nsRefPtr.h

Review of attachment 8518986 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8518986 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/818ef4dc2697
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.