1095177 - [Internet Sharing] Hotspot network cannot be seen by other devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Jeremiah Lee]

Attachment: InternetSharinglogcat.txt

Description:
When hotspot is enabled (on fresh install or reset), other devices cannot see the hotspot network. Results are inconsistent.
   
Hotspot from 2.1 - does not work, after around 8 times (turn off/on) it did work and other devices can see hotspot
Hotspot from 2.2 - When attempting to turn on hotspot, "Wi-Fi hotspot is disabled because there is no data connection." message. Data and wifi are on before attempting to turn on hotspot.
Hotspot from 2.0 - did not work after around 15 tries. Hotspot will turn on, but other devices cannot see the hotspot.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141106001204
2) Make sure device has fresh install or is reset
3) Have 2 Flame devices
4) On test device 1, make sure data and wifi are on
5) Go to Settings > Internet Sharing
6) Go to Hotspot settings
7) Take note of network name and password (or create new password) then tap OK
8) Attempt to turn on Wi-Fi hotspot
9) Observe results. If it remains on, go to other device and attempt to find hotspot network. If hotspot automatically turns off, attempt to turn on again (this will be written as other bug)
10) On device 2 (when hotspot is enabled on device 1) attempt to see hotspot network
11) On device 1, repeat turning on/off the hotspot and see if network appears visible under Wi-Fi on device 2

  
Actual:
On fresh install/reset, turning on hotspot, the hotspot network is not visible by other devices. At times, the hotspot is visible after turning on/off hotspot many times. On 2.2, a message is seen and hotspot cannot be turned on.
  
Expected: 
On device with data/wifi turned on, hotspot can be turned on and can be seen by all nearby devices. Those devices can connect to the network with correct password. This works consistently.
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20141106001204
Gaia: 9658b93b412bdcc0f953d668e8c8e68318c99fb8
Gecko: 76880403db44
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: Similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1066178
  
Repro frequency: 75%
See attached: video clip (http://youtu.be/WYEMqNRMn7c), logcat (InternetSharinglogcat.txt)

Comment 1

[Jeremiah Lee]

On 2.2, hotspot cannot be enabled.

Hotspot from 2.2 - When attempting to turn on hotspot, "Wi-Fi hotspot is disabled because there is no data connection." message. Data and wifi are on before attempting to turn on hotspot.
Note: Can write up other bug if this is not caused by this bug.

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141105160209
Gaia: 7918024c737c4570cacd784f267e28737ae05dea
Gecko: 2114ef80f6ae
Gonk:
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


Issue is also seen on 2.0.

On 2.0 - On fresh install/reset, turning on hotspot, the hotspot network is not visible by other devices. At times, the hotspot is visible after turning on/off hotspot many times. 

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141105183012
Gaia: 5ee26701a4d8db266bfb203b2179f686ce14d8b6
Gecko: dbf49343e889
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0



Note: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

Wifi hotspot will only turn on after multiple search attepmts. Basic functionality is broken. Nominating to block 2.0

Comment 3

[Vincent Chang[:vchang][changyihsin]]

(In reply to Jeremiah Lee from comment #1)
> On 2.2, hotspot cannot be enabled.
> 
> Hotspot from 2.2 - When attempting to turn on hotspot, "Wi-Fi hotspot is
> disabled because there is no data connection." message. Data and wifi are on
> before attempting to turn on hotspot.
> Note: Can write up other bug if this is not caused by this bug.

I think it should be a different bug. But I can't reproduce it though. 

> 
> Device: Flame 2.2 Master (319mb)(Kitkat Base)(Shallow Flash)
> BuildID: 20141105160209
> Gaia: 7918024c737c4570cacd784f267e28737ae05dea
> Gecko: 2114ef80f6ae
> Gonk:
> Version: 36.0a1 (2.2 Master)
> Firmware: V188-1
> User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
> 
> 
> Issue is also seen on 2.0.
> 
> On 2.0 - On fresh install/reset, turning on hotspot, the hotspot network is
> not visible by other devices. At times, the hotspot is visible after turning
> on/off hotspot many times. 
> 
> Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
> BuildID: 20141105183012
> Gaia: 5ee26701a4d8db266bfb203b2179f686ce14d8b6
> Gecko: dbf49343e889
> Version: 32.0 (2.0)
> Firmware: V188-1
> User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
> 
> 
> 
> Note: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)

Can you help to provide logs using below commands in 2.0 and 2.1? 

1. "iptables -nvL"
2. "netcfg"
3. "cat /proc/sys/net/ipv4/ip_forward"
4. "ps | grep -e dnsmasq -e hostapd  -e radish"

It would be nice if you could also provide "adb logcat" log when turning on wifi tethering.

Comment 4

[Jeremiah Lee]

Attachment: adbshell_hotspot

Comment 5

[Jeremiah Lee]

Logcat is attached to bug. Would you like a different logcat?

See attached log files: adbshell_hotspot.txt (for Flame 2.1), adbshell_hotspot2_0.txt (for Flame 2.0)


On Flame 2.1, hotspot is seen by other devices.

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141114001204
Gaia: af6533781356acc62b0f40c9e040aa5b47d3b709
Gecko: 551326425826
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Issue is seen on 2.0.

On 2.0 - On fresh install/reset, turning on hotspot, the hotspot network is
not visible by other devices. At times, the hotspot is visible after turning
on/off hotspot many times. 

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141114000200
Gaia: 28991b28d54fc4ef8112c8fa678bf20f9faca8c8
Gecko: 62294be0fc98
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Jeremiah Lee]

Attachment: adbshell_hotspot2_0

Comment 7

[shawn ku [:sku]]

Hi Kai-Zhen:
 Please help check if this was caused by special char (ex: " " or ".")!!
Thanks!!
Shawn

Comment 8

[Rachelle Yang [:ryang][[e-mail]]]

[Blocking Requested - why for this release]:

Triage: agreed to push this to 2.1 ?
Thank you very much.

Comment 10

[bhavana bajaj [:bajaj]]

[Blocking Requested - why for this release]: 

Renoming it for 2.0 , I think this is a critical issue to be fixed. Vincent, can you help here? Is this flame specific?

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

Shawn, I verified on Flame with pvt build 2.0 and 2.1, I can see the hotspot network which name include special character (" " and ".").

Comment 12

[Wesly Huang (EPM)]

Thanks Kei-Zhen. So based on comment#11 we know it's not related to special chars in SSID, which aligns to our expectation that WIFI hotspot can support special chars in name.

@ Jeremiah: would you help double check if this is seen in 2.1? Per comment 5 it's not but we have status-b2g-v2.1 flag set affected? Thanks.

[Triage] important function broken so tag for 2.0 as of now.

Comment 13

[Jeremiah Lee]

Issue is still seen on 2.1. 

I noticed that editing of the Name of hotspot matters in this issue.
When I just edited the end of Name (for ex, "FirefoxHotspotJLee") or edited complete Name (for ex, "JLee"), other devices could not see hotspot.
When hotspot Name is left as default ("FirefoxHotspot"), other devices could see hotspot.

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120001207
Gaia: f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko: f70a67a7f846
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 14

[Vincent Chang[:vchang][changyihsin]]

One finding today, when 3G data is not connected, the getNetworkInterface() in NetworkManager.js will return null. It causes "enableNat" netd command error and forces wifi hotspot to turn off automatically.

Comment 15

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

Use the default network device name when it is not available. The name is updated when network connection is up.

Comment 16

[Vincent Chang[:vchang][changyihsin]]

I use arbitrary name and set it as default network device name when issuing netd command. I don't see any error message.

Comment 17

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8528234 [details] [diff] [review]
Patch v1.0

Review of attachment 8528234 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Vincent.

Does this happen on usb tethering as well? If yes, should we fix it for usb tethering?

Comment 19

[Josh Cheng [:josh]]

Hi Vincent, do you think bug 1098988 dup this one? Thanks!

Comment 20

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.1

Address the review comment.

Comment 21

[Vincent Chang[:vchang][changyihsin]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3d56e310386e

Comment 22

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3d56e310386e

Comment 23

[Josh Cheng [:josh]]

HI Vincent,
Since this is regression. Could you also raise approval request for Bhavana to land this on 2.0?
Thanks!

Comment 24

[Ryan VanderMeulen [:RyanVM]]

This will need b2g32 and b2g34 approval to land on v2.0 and v2.1.

Comment 25

[Vincent Chang[:vchang][changyihsin]]

Hi Josh, I will do that next week.

Comment 26

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8530149 [details] [diff] [review]
Patch v1.1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 27

[Vincent Chang[:vchang][changyihsin]]

[Approval Request Comment] 
Bug caused by (feature/regressing bug #): Refactor of radiointerfacelayer.js   
User impact if declined: No
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No 
String or UUID changes made by this patch: No

Comment 29

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ed983956f2da
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/70b81490e304

Comment 30

[Josh Cheng [:josh]]

Hi Kai-Zhen,
This need to merger from 2.0 to 2.0M. Thanks!

Comment 32

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/70b81490e304

Comment 33

[Shally Li（leave from Mozilla）]

This issue has been failed verified on Flame v2.2 and Woodduck v2.0.
See attachments: verify_v2.2.MP4 and logcat_v2.2_1210.txt.
Reproduce rate: 4/4

Repro STR:
1) Skip FTU.
2) Both data(Flame:3G,Woodduck:2G) and wifi are turn on.
3) Go to Settings -> Internet Sharing.
4) Go to Hotspot settings.
5) Edit SSID network name and password,then tap OK.
6) Attempt to turn on Wi-Fi hotspot.
**"Wi-Fi hotspot is disabled because there is no data connection." message will pop up while the network signal("3G","H" or "E") is not displayed.
7) Attempt to turn on Wi-Fi hotspot again.
**Hotspot can be turned on and can be seen by all nearby devices while the network signal("3G","H" or "E") is displayed. Those devices can connect to the network with correct password. This works consistently.

Flame 2.2 build:
Gaia-Rev        af3d2f89f391c92667e04676fc0ac971e6021bb7
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a3030140d5df
Build-ID        20141216040205
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141216.075002
FW-Date         Tue Dec 16 07:50:14 EST 2014
Bootloader      L1TC00011880

Woodduck2.0 build:
Gaia-Rev        f3b9806f687fbbd7eba6b0e1f6ebb8bde09840ea
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/12aea1649f5a
Build-ID        20141216000202
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141216.031730
FW-Date         Tue Dec 16 03:17:40 EST 2014
Bootloader      L1TC00011880


This issue has been successfully verified on Flame v2.0&v2.1.
See attachment: verified_v2.0&2.1.mp4
Reproduce rate: 0/3

STR:
1) Skip FTU.
2) Both data(Flame:3G,Woodduck:2G) and wifi are turn on.
3) Go to Settings -> Internet Sharing.
4) Go to Hotspot settings.
5) Edit SSID network name and password,then tap OK.
6) Attempt to turn on Wi-Fi hotspot.
**Hotspot can be turned on and can be seen by all nearby devices. Those devices can connect to the network with correct password. This works consistently.

Flame 2.0 build:
Gaia-Rev        f3b9806f687fbbd7eba6b0e1f6ebb8bde09840ea
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/12aea1649f5a
Build-ID        20141216000202
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141216.031730
FW-Date         Tue Dec 16 03:17:40 EST 2014
Bootloader      L1TC00011880

Flame 2.1 build:
Gaia-Rev        79286eafe67707d1330966c1b1413b2d0de595d9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/222a62b532db
Build-ID        20141216001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141216.034704
FW-Date         Tue Dec 16 03:47:14 EST 2014
Bootloader      L1TC00011880

Comment 34

[Shally Li（leave from Mozilla）]

Attachment: logcat_v2.2_1210.txt

Comment 35

[Shally Li（leave from Mozilla）]

Attachment: verify_v2.2.MP4

Comment 36

[Shally Li（leave from Mozilla）]

Attachment: logcat_woodduck_1242.txt

Comment 37

[Shally Li（leave from Mozilla）]

Attachment: verify_woodduck.MP4

Comment 38

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.0&2.1.MP4

Comment 39

[Peipei Cheng (needinfo if you need my action)]

Shally, 
as you can see from comment 32, the fix is merged into 2.0m at 2014-12-16 08:28:30 PST which is 2014-12-17 00:28:30 UTC+8. So your test build 20141216000202 does not include the fix. 
Could you please verify this bug on the latest woodduck build?

Comment 40

[Shally Li（leave from Mozilla）]

Hi Peipei,
    This issue has been failed verified on latest Woodduck User build.
    See attachments: woodduck_user_1125.MP4 and logcat_user_1125.txt.
    Reproduce rate: 5/5

Repro STR:
1) Skip FTU.
2) Both data(2G) and wifi are turn on.
3) Go to "Internet Sharing".
4) Go to "Hotspot settings".
5) Edit SSID network name and password,then tap OK.
6) Attempt to turn on Wi-Fi hotspot.
**"Wi-Fi hotspot is disabled because there is no data connection." message will pop up while the network signal "E" is not displayed on the status bar.
7) Turn on Wi-Fi hotspot again,meanwhile the network signal("E" or "2G") is displayed on the status bar.
**Hotspot can be turned on and can be seen by all nearby devices. But those devices can't connect to the network successfully for first time. 
8) Turn off and turn on Wi-Fi hotspot again.
**Other devices can connect to the network successfully. This works consistently.

Woodduck build:
Gaia-Rev        7c4ec3494cf465bff688cb4a62f3c2d11a035e14
Gecko-Rev       aa9ece9c8a749095834e7a980166543d985a3af5
Build-ID        20141218054813
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1418853215
FW-Date         Thu Dec 18 05:54:28 CST 2014

Comment 41

[Shally Li（leave from Mozilla）]

Attachment: logcat_user_1125.txt

Comment 42

[Shally Li（leave from Mozilla）]

Attachment: woodduck_user_1125.MP4

Comment 43

[Vincent Chang[:vchang][changyihsin]]

(In reply to Shally from comment #40)
> Hi Peipei,
>     This issue has been failed verified on latest Woodduck User build.
>     See attachments: woodduck_user_1125.MP4 and logcat_user_1125.txt.
>     Reproduce rate: 5/5
> 
> Repro STR:
> 1) Skip FTU.
> 2) Both data(2G) and wifi are turn on.
> 3) Go to "Internet Sharing".
> 4) Go to "Hotspot settings".
> 5) Edit SSID network name and password,then tap OK.
> 6) Attempt to turn on Wi-Fi hotspot.
> **"Wi-Fi hotspot is disabled because there is no data connection." message
> will pop up while the network signal "E" is not displayed on the status bar.

I think this is by design and check in system app[1], right?
[1] http://mxr.mozilla.org/gaia/source/apps/system/js/internet_sharing.js#185 

> 7) Turn on Wi-Fi hotspot again,meanwhile the network signal("E" or "2G") is
> displayed on the status bar.
> **Hotspot can be turned on and can be seen by all nearby devices. But those
> devices can't connect to the network successfully for first time. 

Does this happen in Flame device, too? What is the result if you turn off/on 3G data connection again? 

> 8) Turn off and turn on Wi-Fi hotspot again.
> **Other devices can connect to the network successfully. This works
> consistently.

Comment 44

[Peipei Cheng (needinfo if you need my action)]

Shally,

For the problem in step 6, as Vincent has clairified, it should be by design.

For the problem in step 7, I cannot reproduce it on my device. So I'm wondering is this problem a random issue? If so, what's the rate? I think we should open another bug for this.

Comment 45

[Shally Li（leave from Mozilla）]

(In reply to Vincent Chang[:vchang] from comment #43)
> Does this happen in Flame device, too?

Hi Vincent,
    It doesn't happen on Flame 2.2, please refer Comment 33 or video "verify_v2.2.MP4".


> What is the result if you turn off/on 3G data connection again? 

    If the data network signal("3G","H","E","2G") displays automatically on the status bar,hotspot 
will be opened successfully in step 6.
    On the contrary, if there is no 3G or 2G signal on the status bar that user has opened "Data connection" in Settings->Cellular&Data,hotspot will not be opened successfully in Internet sharing.

Comment 46

[Shally Li（leave from Mozilla）]

(In reply to Peipei Cheng from comment #44)
> Shally,
> For the problem in step 7, I cannot reproduce it on my device. So I'm
> wondering is this problem a random issue? If so, what's the rate? I think we
> should open another bug for this.

Hi Peipei,

    In step 7 of Comment 40 ,I can repro on Woodduck, and reproduce rate is 5/5.

Comment 47

[Vincent Chang[:vchang][changyihsin]]

Hi Seinlin, can you check in Woodduck per comments 33/45?

Comment 48

[Kai-Zhen Li [:seinlin][:kli]]

I think this is related to bug 1105669.