1095220 - FxA migration link is not pretty

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Mark Striemer [:mstriemer]]

Attachment: marketplace-fxa-email.png

The link in the FxA migration email isn't tall enough and it doesn't have enough padding. We should fix it before we sent these out.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: fxa-fxa-email.png

The email from FxA which we are mimicking looks much nicer.

Comment 2

[Stuart Colville [:muffinresearch]]

Looking at the emails I've received it looks like the inline styles on the link are stripped out when it displays like the bug above.

What's interesting is the mail I received via a google apps account (which is forwarded to my usual account) *has* the style attr on the link and looks fine. 

The mail received to a [e-mail] account doesn't have the style on the link.

There's also an issue with link color in Zimbra - that might be it strips out white links - maybe off-white would work - gmail does a similar thing with black #000.

Comment 3

[Mark Striemer [:mstriemer]]

I got the blue-on-blue text unfortunately. Too late to fix this though.

I just went to Show Original in Gmail and noticed this:

> style="text-decoration:none;font-size:20px;font-family:Helvetica;display:block;color:#FFFFF
>  F;padding:15px !important;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%;"

The line-break in the middle of `color:#FFFFFF` was not added for emphasis. That seems bad. Is there a max line length in emails? Maybe our mail server enforces one? That might explain why it looked fine for me locally and through putsmail but it isn't right on production.

Comment 4

[Mark Striemer [:mstriemer]]

I was going to WONTFIX but realised we still send this email out during the migration flow if you're signed in.

Comment 5

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/8ceb47341f34021174c4b0d6c187dc1157644089

I put line breaks in the style attributes on a hunch. Hopefully that fixes it.

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: marketplace-email-updated.png

Just sent myself an email from production that normally was the short button. Worked properly. Screenshot attached.