1095256 - Deleting an entry from EXTRA_JS_MODULES doesn't delete it from the obj. directory

Status: NEW

(Firefox Build System :: General, defect)

Description

[Matthew N. [:MattN]]

I deleted a file from EXTRA_JS_MODULES in bug 1091260 but the file was still being installed in the modules directory without a clobber. The file was still referenced from jar.mn but I made it require pre-processing. See bug 1095234.

Comment 1

[Mike Hommey [:glandium]]

IIRC how this all works, this is because EXTRA_JS_MODULES use install manifests and install manifests don't actually track what used to be installed but is not anymore. gps tell me if I'm wrong.

Comment 2

[Nathan Froyd [:froydnj]]

EXTRA_JS_MODULES uses INSTALL_TARGETS.

Comment 3

[Mike Hommey [:glandium]]

Ah yes, it only uses install-manifests for tests. So that should be fixed by moving EXTRA_JS_MODULES to install manifests, and I think there's an existing bug for that.

Comment 4

[Mike Hommey [:glandium]]

It appears not, but it's kind of a sibling of bug 1058051.

Comment 5

[Gregory Szorc [:gps]]

We can't move EXTRA_JS_MODULES into install manifests until $(FINAL_TARGET) is fully supported in moz.build. And that requires the XPI_NAME= $(MAKE) -C invocations to die.