1095282 - jit-test/tests/atomics/basic-tests.js is going to permafail when Gecko 36 merges to Aurora

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing tests when Gecko 36 merges to Aurora.

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2981184&repo=try

00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--baseline-eager")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--baseline-eager --no-fpu")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--no-baseline --no-ion")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False

Comment 1

[Lars T Hansen [:lth]]

That's extremely curious since the tests actually contain the appropriate feature guards, but I guess I'll have a look.

Comment 2

[Lars T Hansen [:lth]]

The problem appears to be that the Atomics atom is defined eagerly but is not backed by a class, and so we get an NPE in JS_ResolveStandardClass which assumes otherwise, probably rightly so.  The correct fix is to make the existence of that atom dependent on the same #define as the class definition is dependent on (ENABLE_SHARED_ARRAY_BUFFER).

Comment 3

[Lars T Hansen [:lth]]

Attachment: bug1095282-ifdef.diff

Simple fix: Only eagerly define the Atomics symbol when the class it references will also be defined.

Comment 4

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97982a1129a2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97982a1129a2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Verified, thanks :)