jit-test/tests/atomics/basic-tests.js is going to permafail when Gecko 36 merges to Aurora

VERIFIED FIXED in Firefox 36

Status

()

Core
JavaScript Engine
--
critical
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: lth)

Tracking

Trunk
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox36+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
[Tracking Requested - why for this release]: Permafailing tests when Gecko 36 merges to Aurora.

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2981184&repo=try

00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--baseline-eager")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--baseline-eager --no-fpu")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
00:29:55 INFO - FAIL - atomics/basic-tests.js
00:29:55 WARNING - TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/atomics/basic-tests.js | Unknown (code -11, args "--no-baseline --no-ion")
00:29:55 INFO - INFO exit-status : -11
00:29:55 INFO - INFO timed-out : False
Flags: needinfo?(lhansen)
(Assignee)

Comment 1

4 years ago
That's extremely curious since the tests actually contain the appropriate feature guards, but I guess I'll have a look.
Flags: needinfo?(lhansen)
(Assignee)

Comment 2

4 years ago
The problem appears to be that the Atomics atom is defined eagerly but is not backed by a class, and so we get an NPE in JS_ResolveStandardClass which assumes otherwise, probably rightly so.  The correct fix is to make the existence of that atom dependent on the same #define as the class definition is dependent on (ENABLE_SHARED_ARRAY_BUFFER).
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 8518820 [details] [diff] [review]
bug1095282-ifdef.diff

Simple fix: Only eagerly define the Atomics symbol when the class it references will also be defined.
Attachment #8518820 - Flags: review?(jdemooij)

Updated

4 years ago
Attachment #8518820 - Flags: review?(jdemooij) → review+
(Reporter)

Updated

4 years ago
Blocks: 1095276
(Reporter)

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/97982a1129a2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(Reporter)

Comment 6

4 years ago
Verified, thanks :)
Status: RESOLVED → VERIFIED
status-firefox36: --- → verified
tracking-firefox36: ? → +
You need to log in before you can comment on or make changes to this bug.