1095308 - Remove some compileAndGo checks from frontend::CompileScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We have:

235     MOZ_ASSERT_IF(evalCaller, options.compileAndGo);

and then later in the function:

278     bool savedCallerFun = options.compileAndGo &&
279                           evalCaller && evalCaller->functionOrCallerFunction();

and

315     if (options.compileAndGo && evalCaller && evalCaller->functionOrCallerFunction()) {

so I claim those options.compileAndGo checks after the assert are redundant.  At least if we trust the assert.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove some compileAndGo checks from frontend::CompileScript

Comment 2

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1e31309483

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6b1e31309483