1095325 - [Stingray] system cannot open activity for home after we kill the home app and restart home app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

smart-system has _activeApp = null when we use make install-gaia to reinstall the smart-home app. That makes us unable to send an activity when smart-home is shown.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

Hi Rex,

Please review this patch.

The root cause of this bug is:
1. homescreen_window.js calls restart while browserclose or browsererror event got.[1]
2. restart calls kill function[2]
3. kill function sends terminated event[3]
4. app_window_manager reset _activeApp to null[4]
5. restart only fire "opened" event when it calls open[5] <== in this case, the HomescreenWindow is not registered to AppWindowManager._apps['...']

[1] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/homescreen_window.js#L135
[2] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/homescreen_window.js#L148
[3] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/app_window.js#L444
[4] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/app_window_manager.js#L415-L417
[5] https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/homescreen_window.js#L158

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8518696 [details] [review]
patch for this bug

Looks good to me.
Thanks for the quick fix!

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

gaia-try is green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7b959d0d37b6

merged to master:
https://github.com/mozilla-b2g/gaia/commit/552512ce1af640dbe102ffd4c0879a7d90ea1b52

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I just made a try and seems it don't actually solve the problem :-/

Nothing is sent to smart-home after sending activity. I wonder if it's just a Gecko issue.
I'll try to trace it.