1095369 - [FFOS2.0][Woodduck][Browser]Wallpaper will display when edit bookmark

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #811498 +++
 Created an attachment (id=976126)
 picture
 
 DEFECT DESCRIPTION:
  Wallpaper will display when edit bookmark
 
  REPRODUCING PROCEDURES:
  1.launch browser->open one website->tap[star]icon->[Bookmark]
  2.tap[star]icon->[Edit Bookmark]->tap input field
  3.Switch to landscape mode->Wallpaper will display-->KO1
 
 
  EXPECTED BEHAVIOUR:
  KO1:lpaper won't display
 
  中文描述：
  1.打开一网页->添加为书签
  2.点击[五角星]->编辑书签->点击输入域
  3.把手机切换到横屏->壁纸闪现-->KO1
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
  free test
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  moderate
 
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:
  Fire e 1.3 SW28C+CN10 没有壁纸出现
 ++++++++++ end of initial bug #811498 description ++++++++++
 
 		
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: jrdlog_811498.rar

Comment 2

[sync-1]

Attachment: picture

Comment 3

[Josh Cheng [:josh]]

Hi Yi-Fan,
Could you please have a check for this bug with bookmark issue? Thanks!

Comment 4

[yifan [:yifan][:yliao]]

Attachment: resizing log

When changing orientation from portrait to landscape in the browser app with keyboard on, from the log of the system app we could see that the first time the browser app gets resized, the height is calculated by the layout_manager.js with the portrait keyboard which is 205px. This is later corrected after the keyboard resized. So between these resize events, the system background would be visible like the picture in the previous attachment.

Comment 5

[yifan [:yifan][:yliao]]

Hi Alive,

This seems to also affect apps that change orientations. How would you suggest we fix this bug?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Picture#1 is software home button gap I guess.
No idea what is Picture#2 doing and what you really want
* Don't want to see wallpaper when resizing => call fadeOut on homescreenWindow
* Don't want to be resized when holding home in landscape mode => ?
* More magical stuff like rotating the screen while resizing

Comment 7

[yifan [:yifan][:yliao]]

Attachment: pull request for v2.0

Thank you Alive!

When changing orientation from portrait to landscape and resizing with keyboard on, the layout manager in the system app will resize the height of the active app first with the keyboard height in portrait (line 55 in layout_manager.js). When the height of the keyboard in portrait mode is bigger than the height in landscape mode, the calculated height of the active app will be smaller than it should've been. The system wallpaper is visible at the mean time. Subsequent resize events later will immediately correct the active app height using the correct landscape keyboard height.

The resizing event sequence is 'resize' --> 'keyboardchange' --> 'keyboardchange'. This patch disables the keyboard height check in the 'resize' event since it'd be incorrect during orientation change, which would display part of the system wallpaper in a flash.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8520464 [details] [review]
pull request for v2.0

Good investigation, LGTM for v2.0, please make a master patch *with test* as well. Thanks.

Comment 9

[yifan [:yifan][:yliao]]

Attachment: pull request for master

Thank you for the review! Here's the PR with test for the master branch.

Comment 10

[yifan [:yifan][:yliao]]

Merged into master
https://github.com/mozilla-b2g/gaia/pull/26050

Test completed
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=93b1f0c655f4

Comment 11

[yifan [:yifan][:yliao]]

Comment on attachment 8521121 [details] [review]
pull request for master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1095369
[User impact] if declined: When changing orientation with keyboard on in apps a user will see the wallpaper flashes.
[Testing completed]: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=93b1f0c655f4
[Risk to taking this patch] (and alternatives if risky): N/A
[String changes made]: N/A

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: PR to v2.0m

Ni myself to merge it when the tree is opened.

Comment 13

[bhavana bajaj [:bajaj]]

Yifan, is this a regression in 2.0 ?

Comment 14

[yifan [:yifan][:yliao]]

No, it's not a regression.

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to yifan [:yifan][:yliao] from comment #14)
> No, it's not a regression.

so this is better off riding the trains for 2.0 given the release is done there but I'll take it on 2.1

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/cabbbf113debc59ae8499974f4dd3cb1306d257b

Comment 17

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/60146ec47cd38a8be8ed22e0116902eceb9ac067

Comment 18

[Shine(Leave from Mozilla)]

Attachment: Woodduck

Comment 19

[Shine(Leave from Mozilla)]

The verify result as follows：
Woodduck 2.0: in step3, device doesn’t support landscape mode now. please see attachment: verify video~1.mp4
Flame 2.1& 2.2: on Flame Browser, there’s no [Star] icon and doesn’t support Bookmarks function.
Woodduck2.0 build:
Gaia-Rev        3a98f1287fa7b604891220ba5d86982ae8f9971e
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141120103003
Version         32.0
Flame 2.1 build:
Gaia-Rev        f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f70a67a7f846
Build-ID        20141120001207
Version         34.0
Flame2.2 build:
Gaia-Rev        1abe09b4925547699dfdb2d358aed019137c3aa6
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/6ce1b906c690
Build-ID        20141120040205
Version         36.0a1

Comment 20

[sync-1]

The new ref is updated by  with patch_delivery script!
 
     ###%%%comment:[FFOS2.0][Woodduck][Browser]Wallpaper will display when edit bookmark     ###%%%bug number:834085     ###%%%product name:soul35-ff-v1.0-dint     ###%%%root cause:Coding     ###%%%Module_Impact:no     ###%%%Test_Suggestion:     ###%%%Solu
 
 Branch: refs/heads/soul35-ff-v1.0-dint
 http://10.92.32.10:8081/#change,34113
 http://10.92.32.10/gitweb.cgi?p=firefox/quic/lf/b2g/mozilla/gaia.git;a=commit;h=2631015ad1eae22d10b506990ba7b0dd3b38b69e

Comment 21

[Hubert Lu[:hlu] <[e-mail]>]

According to comment 19, this issue does not exit on v2.0m, v2.1 and v2.2.