Comment on attachment 8519889 [details] [review] https://github.com/mozilla-b2g/gaia/pull/26004 Dale - might have conflicted you with the eme work. Can you rebase against master and submit again? I'm curious about what the try results will do here, I think at least the marketplace test is failing here. Thanks!
rebased and running on try now, will r? when green
Comment on attachment 8519889 [details] [review] https://github.com/mozilla-b2g/gaia/pull/26004 Try run was green aside from unit tests I missed, fixed those so should be green now
Comment on attachment 8519889 [details] [review] https://github.com/mozilla-b2g/gaia/pull/26004 Looks good to me. I left a comment on github. Your choice if you want to address it. I'd imagine that we'd want to move the path and query string into the marketplace file in case we ever decide to use more marketplace APIs. Though I guess we also need to do this for the everything.me url as well.
Attachment #8519889 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.