Markerplace API access should be configurable

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: daleharvey, Assigned: daleharvey)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Blocks: 1030045
(Assignee)

Updated

4 years ago
Assignee: nobody → dale
Whiteboard: [systemsfe]
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Dale - might have conflicted you with the eme work. Can you rebase against master and submit again? I'm curious about what the try results will do here, I think at least the marketplace test is failing here. Thanks!
Flags: needinfo?(dale)
Attachment #8519889 - Flags: review?(kgrandon)
(Assignee)

Comment 3

4 years ago
rebased and running on try now, will r? when green
Flags: needinfo?(dale)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Try run was green aside from unit tests I missed, fixed those so should be green now
Attachment #8519889 - Flags: review?(kgrandon)
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Looks good to me. I left a comment on github. Your choice if you want to address it. I'd imagine that we'd want to move the path and query string into the marketplace file in case we ever decide to use more marketplace APIs. Though I guess we also need to do this for the everything.me url as well.
Attachment #8519889 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 6

4 years ago
https://github.com/daleharvey/gaia/commit/ec1ad1709e90ab398e7788f4a3e3430a2a316272
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.