1095466 - Markerplace API access should be configurable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/26004

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Dale - might have conflicted you with the eme work. Can you rebase against master and submit again? I'm curious about what the try results will do here, I think at least the marketplace test is failing here. Thanks!

Comment 3

[Dale Harvey (:daleharvey)]

rebased and running on try now, will r? when green

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Try run was green aside from unit tests I missed, fixed those so should be green now

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Looks good to me. I left a comment on github. Your choice if you want to address it. I'd imagine that we'd want to move the path and query string into the marketplace file in case we ever decide to use more marketplace APIs. Though I guess we also need to do this for the everything.me url as well.

Comment 6

[Dale Harvey (:daleharvey)]

https://github.com/daleharvey/gaia/commit/ec1ad1709e90ab398e7788f4a3e3430a2a316272