Closed Bug 1095466 Opened 10 years ago Closed 10 years ago

Markerplace API access should be configurable

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/26004
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
      No description provided.
Blocks: 1030045
Assignee: nobody → dale
Whiteboard: [systemsfe]

        Attachment #8519889 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Dale - might have conflicted you with the eme work. Can you rebase against master and submit again? I'm curious about what the try results will do here, I think at least the marketplace test is failing here. Thanks!
Flags: needinfo?(dale)

        Attachment #8519889 -
        Flags: review?(kgrandon)

    
    

    
  
rebased and running on try now, will r? when green
Flags: needinfo?(dale)

    
    

    
  
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Try run was green aside from unit tests I missed, fixed those so should be green now

        Attachment #8519889 -
        Flags: review?(kgrandon)

    
    

    
  
Comment on attachment 8519889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/26004

Looks good to me. I left a comment on github. Your choice if you want to address it. I'd imagine that we'd want to move the path and query string into the marketplace file in case we ever decide to use more marketplace APIs. Though I guess we also need to do this for the everything.me url as well.

        Attachment #8519889 -
        Flags: review?(kgrandon) → review+

    
    

    
  
https://github.com/daleharvey/gaia/commit/ec1ad1709e90ab398e7788f4a3e3430a2a316272
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: